emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)]
Date: Tue, 28 May 2019 11:02:32 +0200	[thread overview]
Message-ID: <87woibq7dj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CCEC7A93-348A-4532-B73E-858831BFAA77@gmail.com> (Andrii Kolomoiets's message of "Fri, 17 May 2019 15:15:01 +0300")

Hello,

Andrii Kolomoiets <andreyk.mad@gmail.com> writes:

> The org-frame-title-format-backup variable is initialized on
> org-clock.el loading and future changes to frame-title-format is
> ignored:
>
> 1. emacs -Q
> 2. M-: frame-title-format
>    It's "%b"
> 3. M-: (require 'org-clock)
> 4. (setq frame-title-format "%b bar")
> 5. C-x b test.org
> 6. M-x org-mode
> 7. Insert heading (M-RET foo)
> 8. M-x org-clock-in
> 9. M-x org-clock-out
> 10. M-: frame-title-format
>     It's "%b" again
>     
> With provided patch org-frame-title-format-backup is initialized on
> org-clock-in. Also frame-title-format is restored to
> org-frame-title-format-backup only if current frame-title-format is
> equal to org-clock-frame-title-format in case frame title format is
> changed after org-clock-in.

Thank you.

I think this could be factored out a bit, for example creating a simple
function taking care of updating `frame-title-format' if needed.

Also, could you provide a proper commit message and use git format-patch
to send it again?

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-05-28  9:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 12:15 [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)] Andrii Kolomoiets
2019-05-28  9:02 ` Nicolas Goaziou [this message]
2019-05-28 13:57   ` [PATCH] org-clock.el: Fix restore of frame-title-format Andrii Kolomoiets
2019-05-28 17:59     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woibq7dj.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=andreyk.mad@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).