From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-clock.el: Fix restore of frame-title-format
Date: Tue, 28 May 2019 19:59:38 +0200 [thread overview]
Message-ID: <87k1eaqx2t.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <85266002-C647-4624-9E50-C73E89151BF3@gmail.com> (Andrii Kolomoiets's message of "Tue, 28 May 2019 16:57:42 +0300")
Hello,
Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
> * lisp/org-clock.el (org-frame-title-format-backup): Use nil as initial value.
> (org-clock-in): set `org-frame-title-format-backup' to `frame-title-format'.
> (org-clock-restore-frame-title-format): New function.
> (org-clock-out): Use it.
> (org-clock-cancel): Use it.
>
> The problem was that the `org-frame-title-format-backup' variable is
> initialized on org-clock.el loading and future changes to `frame-title-format'
> is ignored.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2019-05-28 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 12:15 [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)] Andrii Kolomoiets
2019-05-28 9:02 ` Nicolas Goaziou
2019-05-28 13:57 ` [PATCH] org-clock.el: Fix restore of frame-title-format Andrii Kolomoiets
2019-05-28 17:59 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1eaqx2t.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=andreyk.mad@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).