From: Kyle Meyer <kyle@kyleam.com>
To: Bastien <bzg@gnu.org>, Kevin Foley <kevin@kevinjfoley.me>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix `org-babel-detangle' handling of false positives
Date: Sun, 24 May 2020 16:17:37 +0000 [thread overview]
Message-ID: <87wo515mu6.fsf@kyleam.com> (raw)
In-Reply-To: <87wo51moo1.fsf@gnu.org>
Hi Kevin and Bastien,
This change (010d1e3b6) needs a follow-up patch. Running the tests now
leaves the working tree dirty:
diff --git a/testing/examples/babel.org b/testing/examples/babel.org
index b0942800a..e95a65b85 100644
--- a/testing/examples/babel.org
+++ b/testing/examples/babel.org
@@ -499,5 +499,5 @@ ** linked content to detangle
:ID: 73115FB0-6565-442B-BB95-50195A499EF4
:END:
#+begin_src emacs-lisp :tangle yes :comments link
- ;; detangle
+ ;; detangle changes
#+end_src
Kevin, could you look into updating the test to avoid changing the repo
state?
Thanks.
next prev parent reply other threads:[~2020-05-24 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 23:15 Kevin Foley
2020-02-01 9:22 ` Bastien
2020-02-09 16:24 ` Kevin Foley
2020-02-10 6:22 ` Bastien
2020-05-22 14:37 ` Kevin Foley
2020-05-22 15:36 ` Bastien
2020-05-24 12:30 ` Kevin Foley
2020-05-24 13:46 ` Bastien
2020-05-24 16:17 ` Kyle Meyer [this message]
2020-05-24 18:14 ` Kevin Foley
2020-05-24 20:19 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo515mu6.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=kevin@kevinjfoley.me \
--subject='Re: [PATCH] Fix `org-babel-detangle'\'' handling of false positives' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).