emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Kevin Foley <kevin@kevinjfoley.me>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix `org-babel-detangle' handling of false positives
Date: Sun, 24 May 2020 20:19:10 +0000	[thread overview]
Message-ID: <87r1v9rsqp.fsf@kyleam.com> (raw)
In-Reply-To: <m2r1v9ci96.fsf@Kevins-MacBook-Pro.local.i-did-not-set--mail-host-address--so-tickle-me>

Kevin Foley writes:

> Kyle Meyer <kyle@kyleam.com> writes:
>
>> Kevin, could you look into updating the test to avoid changing the repo
>> state?
>
> Sorry about that.  Do you have any suggestions on how to avoid changing
> the state or any examples of similar tests?
>
> I tried the following to replace the file with it's original contents
> but it doesn't seem to be working as I intend.  I also worry it's a
> convoluted approach and there may be a simpler way.

Thanks for taking a look.  The dirty working tree state happens when
running all the ob-tangle tests but not when running just the test you
added [*].  That makes me think the core issue is that the change from
your test stays around to be save by another test.  So I suspect you can
avoid the dirty state by just wrapping the test in unwind-protect,
making sure to kill the Org buffer before detangle-false-positive exits.

[*] Specifically, running

      make BTEST_RE='ob-tangle' test-dirty

    versus

      make BTEST_RE='detangle' test-dirty


      reply	other threads:[~2020-05-24 20:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 23:15 Kevin Foley
2020-02-01  9:22 ` Bastien
2020-02-09 16:24   ` Kevin Foley
2020-02-10  6:22     ` Bastien
2020-05-22 14:37       ` Kevin Foley
2020-05-22 15:36         ` Bastien
2020-05-24 12:30           ` Kevin Foley
2020-05-24 13:46             ` Bastien
2020-05-24 16:17               ` Kyle Meyer
2020-05-24 18:14                 ` Kevin Foley
2020-05-24 20:19                   ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1v9rsqp.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin@kevinjfoley.me \
    --subject='Re: [PATCH] Fix `org-babel-detangle'\'' handling of false positives' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).