* [PATCH] make export dispatcher go away promptly
@ 2011-02-04 15:05 Dan Davison
2011-02-04 16:21 ` Carsten Dominik
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Davison @ 2011-02-04 15:05 UTC (permalink / raw)
To: emacs-orgmode
Following on from Stephen's recent post, a
thing-that-slightly-bothers-me is the way the export dispatcher window
doesn't go away until export is complete. I've briefly looked at the
code twice now and it wasn't obvious to me why the save-window-excursion
(line 941 org-exp.el) wasn't already doing what I wanted. However, the
change below seems to have the effect I wanted. While this particular
solution may be a hack, I wonder whether people would prefer its
behaviour? E.g. try exporting this:
#+title: title
#+begin_src sh :exports results
sleep 5 && echo hello
#+end_src
export can often take several seconds and it's nice to be able to zone
out looking at your org document rather than the dispatcher window.
Modified lisp/org-exp.el
diff --git a/lisp/org-exp.el b/lisp/org-exp.el
index 13fa549..3d291e2 100644
--- a/lisp/org-exp.el
+++ b/lisp/org-exp.el
@@ -963,6 +963,7 @@ value of `org-export-run-in-background'."
(setq r1 (read-char-exclusive)))
(error "No enclosing node with LaTeX_CLASS or EXPORT_FILE_NAME")
)))))
+ (redisplay)
(and bpos (goto-char bpos))
(setq r2 (if (< r1 27) (+ r1 96) r1))
(unless (setq ass (assq r2 cmds))
(I see that (sit-for .0001) is used in a couple of places in Org for
this effect, so maybe that should be used instead.)
Dan
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] make export dispatcher go away promptly
2011-02-04 15:05 [PATCH] make export dispatcher go away promptly Dan Davison
@ 2011-02-04 16:21 ` Carsten Dominik
2011-02-04 19:02 ` [Accepted] " Bastien Guerry
2011-02-04 19:03 ` [PATCH] " Bastien
2 siblings, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2011-02-04 16:21 UTC (permalink / raw)
To: Dan Davison; +Cc: emacs-orgmode
On Feb 4, 2011, at 4:05 PM, Dan Davison wrote:
> Following on from Stephen's recent post, a
> thing-that-slightly-bothers-me is the way the export dispatcher window
> doesn't go away until export is complete. I've briefly looked at the
> code twice now and it wasn't obvious to me why the save-window-
> excursion
> (line 941 org-exp.el) wasn't already doing what I wanted. However, the
> change below seems to have the effect I wanted. While this particular
> solution may be a hack, I wonder whether people would prefer its
> behaviour? E.g. try exporting this:
>
> #+title: title
>
> #+begin_src sh :exports results
> sleep 5 && echo hello
> #+end_src
>
> export can often take several seconds and it's nice to be able to zone
> out looking at your org document rather than the dispatcher window.
>
> Modified lisp/org-exp.el
> diff --git a/lisp/org-exp.el b/lisp/org-exp.el
> index 13fa549..3d291e2 100644
> --- a/lisp/org-exp.el
> +++ b/lisp/org-exp.el
> @@ -963,6 +963,7 @@ value of `org-export-run-in-background'."
> (setq r1 (read-char-exclusive)))
> (error "No enclosing node with LaTeX_CLASS or
> EXPORT_FILE_NAME")
> )))))
> + (redisplay)
> (and bpos (goto-char bpos))
> (setq r2 (if (< r1 27) (+ r1 96) r1))
> (unless (setq ass (assq r2 cmds))
Looks good to me.
- Carsten
>
>
> (I see that (sit-for .0001) is used in a couple of places in Org for
> this effect, so maybe that should be used instead.)
>
> Dan
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Accepted] make export dispatcher go away promptly
2011-02-04 15:05 [PATCH] make export dispatcher go away promptly Dan Davison
2011-02-04 16:21 ` Carsten Dominik
@ 2011-02-04 19:02 ` Bastien Guerry
2011-02-04 19:03 ` [PATCH] " Bastien
2 siblings, 0 replies; 4+ messages in thread
From: Bastien Guerry @ 2011-02-04 19:02 UTC (permalink / raw)
To: emacs-orgmode
Patch 582 (http://patchwork.newartisans.com/patch/582/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3Cm1oc6rq1q8.fsf%40gmail.com%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] make export dispatcher go away promptly
> Date: Fri, 04 Feb 2011 20:05:35 -0000
> From: Dan Davison <dandavison7@gmail.com>
> X-Patchwork-Id: 582
> Message-Id: <m1oc6rq1q8.fsf@gmail.com>
> To: emacs-orgmode@gnu.org
>
> Following on from Stephen's recent post, a
> thing-that-slightly-bothers-me is the way the export dispatcher window
> doesn't go away until export is complete. I've briefly looked at the
> code twice now and it wasn't obvious to me why the save-window-excursion
> (line 941 org-exp.el) wasn't already doing what I wanted. However, the
> change below seems to have the effect I wanted. While this particular
> solution may be a hack, I wonder whether people would prefer its
> behaviour? E.g. try exporting this:
>
> #+title: title
>
> #+begin_src sh :exports results
> sleep 5 && echo hello
> #+end_src
>
> export can often take several seconds and it's nice to be able to zone
> out looking at your org document rather than the dispatcher window.
>
> Modified lisp/org-exp.el
>
>
> (I see that (sit-for .0001) is used in a couple of places in Org for
> this effect, so maybe that should be used instead.)
>
> Dan
>
>
> diff --git a/lisp/org-exp.el b/lisp/org-exp.el
> index 13fa549..3d291e2 100644
> --- a/lisp/org-exp.el
> +++ b/lisp/org-exp.el
> @@ -963,6 +963,7 @@ value of `org-export-run-in-background'."
> (setq r1 (read-char-exclusive)))
> (error "No enclosing node with LaTeX_CLASS or EXPORT_FILE_NAME")
> )))))
> + (redisplay)
> (and bpos (goto-char bpos))
> (setq r2 (if (< r1 27) (+ r1 96) r1))
> (unless (setq ass (assq r2 cmds))
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] make export dispatcher go away promptly
2011-02-04 15:05 [PATCH] make export dispatcher go away promptly Dan Davison
2011-02-04 16:21 ` Carsten Dominik
2011-02-04 19:02 ` [Accepted] " Bastien Guerry
@ 2011-02-04 19:03 ` Bastien
2 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2011-02-04 19:03 UTC (permalink / raw)
To: Dan Davison; +Cc: emacs-orgmode
Dan Davison <dandavison7@gmail.com> writes:
> Following on from Stephen's recent post, a
> thing-that-slightly-bothers-me is the way the export dispatcher window
> doesn't go away until export is complete. I've briefly looked at the
> code twice now and it wasn't obvious to me why the save-window-excursion
> (line 941 org-exp.el) wasn't already doing what I wanted. However, the
> change below seems to have the effect I wanted. While this particular
> solution may be a hack, I wonder whether people would prefer its
> behaviour? E.g. try exporting this:
>
> #+title: title
>
> #+begin_src sh :exports results
> sleep 5 && echo hello
> #+end_src
>
> export can often take several seconds and it's nice to be able to zone
> out looking at your org document rather than the dispatcher window.
I applied this patch, thanks!
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-04 19:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-04 15:05 [PATCH] make export dispatcher go away promptly Dan Davison
2011-02-04 16:21 ` Carsten Dominik
2011-02-04 19:02 ` [Accepted] " Bastien Guerry
2011-02-04 19:03 ` [PATCH] " Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).