emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Brice Waegenire <brice.wge@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes
Date: Wed, 29 Apr 2015 20:38:50 -0400	[thread overview]
Message-ID: <87vbgebgbp.fsf@kyleam.com> (raw)
In-Reply-To: <CAL5NfX2YMpwX6pSK_taJQbWKLq9bZfYUjHTqC-=RobSd2mrvzA@mail.gmail.com> (Brice Waegenire's message of "Wed, 29 Apr 2015 23:52:58 +0200")

Brice Waegenire <brice.wge@gmail.com> wrote:
> I have took in consideration all of your points, is it better now?
> The current patch doesn't overwrite the present behavior of
> org-set-timer it only add the possibility to use hh:mm:ss format.

Thanks.

> From 8d6e379f3ed432511c613a0cf40804d2de1764b8 Mon Sep 17 00:00:00 2001
> From: Brice Waegeneire <brice.wge@gmail.com>
> Date: Fri, 24 Apr 2015 14:18:45 +0200
> Subject: [PATCH] org-timer.el: hh:mm:ss format for setting a timer
>
> * lisp/org-timer.el (org-timer-set-timer): Add support for hh:mm:ss format.
>
> * testing/lisp/test-org-timer.el (test-org-timer/set-timer): Add hh:mm:ss format in the test.

Minor: ChangeLog lines tend to be filled at around 72 characters.

[...]
>  		     (read-from-minibuffer
> -		      "How many minutes left? "
> +		      "How much time left? (minutes or h:mm:ss) "
>  		      (if (not (eq org-timer-default-timer 0))
> -			  (number-to-string org-timer-default-timer))))))
> +			  (eval org-timer-default-timer))))))

The defcustom for org-timer-default-timer now specifies a string and is
set to "0", so `(not (eq org-timer-default-timer 0))` will return t for
the default value of org-timer-default-timer.  Something like

    (and (not (string= org-timer-default-timer "0"))
         org-timer-default-timer)

would be needed to keep the old behavior (i.e., only insert the value of
org-timer-default-timer as the initial prompt input if the user has
changed it).

> +    (if (string-match "^[0-9]+$" minutes)
> +	(setq minutes (concat minutes ":00")))

Minor: `when` could be used here.

Aside from that, this looks good to me.  Thoughts from Nicolas or
others?

next prev parent reply	other threads:[~2015-04-30  0:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 12:48 [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes Brice Waegenire
2015-04-24 16:49 ` Kyle Meyer
2015-04-29 21:52   ` Brice Waegenire
2015-04-30  0:38     ` Kyle Meyer [this message]
2015-05-01  8:47     ` Nicolas Goaziou
2015-05-05 14:34       ` Brice Waegenire
2015-05-07 20:09         ` Nicolas Goaziou
2015-06-02 21:04           ` Brice Waegenire
2015-06-02 21:24             ` Nicolas Goaziou
2015-06-03 22:00               ` Brice Waegenire
2015-06-06  7:30                 ` Nicolas Goaziou
2015-08-05  0:00                   ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbgebgbp.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=brice.wge@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).