From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Brice Waegenire <brice.wge@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes
Date: Thu, 07 May 2015 22:09:06 +0200 [thread overview]
Message-ID: <876184i1zx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAL5NfX3+OKgxb+2pbMeAF-j8E24LE33rZ9JVjwxbbA9=a_t=ww@mail.gmail.com> (Brice Waegenire's message of "Tue, 5 May 2015 16:34:29 +0200")
Brice Waegenire <brice.wge@gmail.com> writes:
> Thanks for help on this!
> Here is the last version of the patch taking into account all of your
> comments.
Thank you.
> (read-from-minibuffer
> - "How many minutes left? "
> - (if (not (eq org-timer-default-timer 0))
> - (number-to-string org-timer-default-timer))))))
> + "How much time left? (minutes or h:mm:ss) "
> + (when (not (string-equal org-timer-default-timer "0"))
Nitpick: `unless'
> + (eval org-timer-default-timer))))))
Since `org-timer-default-timer' is a string, there's no need to eval it.
BTW, did you sign FSF papers already? If not, you need to add TINYCHANGE
to the end of the commit message.
Regards,
next prev parent reply other threads:[~2015-05-07 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 12:48 [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes Brice Waegenire
2015-04-24 16:49 ` Kyle Meyer
2015-04-29 21:52 ` Brice Waegenire
2015-04-30 0:38 ` Kyle Meyer
2015-05-01 8:47 ` Nicolas Goaziou
2015-05-05 14:34 ` Brice Waegenire
2015-05-07 20:09 ` Nicolas Goaziou [this message]
2015-06-02 21:04 ` Brice Waegenire
2015-06-02 21:24 ` Nicolas Goaziou
2015-06-03 22:00 ` Brice Waegenire
2015-06-06 7:30 ` Nicolas Goaziou
2015-08-05 0:00 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876184i1zx.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=brice.wge@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).