emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>,
	Thorsten Jolitz <tjolitz@gmail.com>
Subject: Re: Use of deprecated org-log-note-marker variable in outshine
Date: Fri, 08 Jan 2016 14:21:41 +0100	[thread overview]
Message-ID: <87vb74p5p6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY0qeGocXXqwDjFqp5a7vXGtYhEmm7dLXK8G1ubpgRd12w@mail.gmail.com> (Kaushal Modi's message of "Thu, 7 Jan 2016 11:56:40 -0500")

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

>> Was it just removed, or rather renamed or replaced by something else?
>> Maybe the fix would be trivial if somebody with insights about the
>> change could give some hints?
>
> I have never needed to use this function, so I cannot comment on it. So
> asking Nicolas for help regarding this.

Actually, it was a mistake to remove the variable in the first place. As
a consequence, I re-introduced it in master.

However, it doesn't store the same location as before, i.e., it merely
points to the entry where the note is going to be added instead of the
accurate location for the note.

As a first approximation, I think 

  (with-current-buffer (marker-buffer org-log-note-marker)
    (goto-char (org-log-note-marker))
    (copy-marker (org-log-beginning)))

is close to what `org-log-note-marker' used to be.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2016-01-08 13:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 23:09 Use of deprecated org-log-note-marker variable in outshine Kaushal Modi
2016-01-07 16:38 ` Thorsten Jolitz
2016-01-07 16:56   ` Kaushal Modi
2016-01-08 13:21     ` Nicolas Goaziou [this message]
2016-01-08 15:45       ` Kaushal Modi
2016-01-08 16:28       ` Nicolas Richard
2016-01-31 22:11         ` Nicolas Goaziou
2016-02-03 23:04       ` Thorsten Jolitz
2016-02-03 23:02 ` Thorsten Jolitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb74p5p6.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=tjolitz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).