* org-bbdb and 1. March
@ 2008-10-05 17:25 Tom Rauchenwald
2008-10-06 16:45 ` Thomas Baumann
0 siblings, 1 reply; 4+ messages in thread
From: Tom Rauchenwald @ 2008-10-05 17:25 UTC (permalink / raw)
To: emacs-orgmode
Hi,
I noticed a bug with org-bbdb. If I enter a anniversary for the 1st of
March, org doesn't show it in the agenda and complains with "Bad sexp at
line 9 in /home/sec/org/geburtstage.org: (org-bbdb-anniversaries)"
It seems to have to do with the special-casing of the 29th of February
in leap-years, i.e. when I comment the following lines:
,----
| ;; we don't want to miss people born on Feb. 29th
| (when (and (= m 3) (= d 1) (not (calendar-leap-year-p y)))
| (setq annivs (cons annivs (gethash (list 2 29) org-bbdb-anniv-hash))))
`----
the bug goes away.
Thanks,
Tom
--
Last week, Japanese scientists explaced... placed explosive detonators
at the bottom of Lake Loch Ness to blow Nessie out of the water.
-- Napoleon Dynamite
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: org-bbdb and 1. March
2008-10-05 17:25 org-bbdb and 1. March Tom Rauchenwald
@ 2008-10-06 16:45 ` Thomas Baumann
2008-10-06 18:45 ` Carsten Dominik
2008-10-06 20:11 ` Tom Rauchenwald
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Baumann @ 2008-10-06 16:45 UTC (permalink / raw)
To: emacs-orgmode
confirmed, thanks for reporting.
Carsten surely will checkin the following patch soon.
Thomas
diff --git a/lisp/org-bbdb.el b/lisp/org-bbdb.el
index ad5265f..044b74b 100644
--- a/lisp/org-bbdb.el
+++ b/lisp/org-bbdb.el
@@ -291,11 +291,16 @@ This is used by Org to re-create the anniversary hash table."
(y (nth 2 date)) ; year
(annivs (gethash (list m d) org-bbdb-anniv-hash))
(text ())
- split class form rec)
+ split class form rec recs)
;; we don't want to miss people born on Feb. 29th
- (when (and (= m 3) (= d 1) (not (calendar-leap-year-p y)))
- (setq annivs (cons annivs (gethash (list 2 29) org-bbdb-anniv-hash))))
+ (when (and (= m 3) (= d 1)
+ (not (null (gethash (list 2 29) org-bbdb-anniv-hash)))
+ (not (calendar-leap-year-p y)))
+ (setq recs (gethash (list 2 29) org-bbdb-anniv-hash))
+ (while (setq rec (pop recs))
+ (push rec annivs)))
+
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: Re: org-bbdb and 1. March
2008-10-06 16:45 ` Thomas Baumann
@ 2008-10-06 18:45 ` Carsten Dominik
2008-10-06 20:11 ` Tom Rauchenwald
1 sibling, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2008-10-06 18:45 UTC (permalink / raw)
To: Thomas Baumann; +Cc: emacs-orgmode
Applied, thanks.
- Carsten
On Oct 6, 2008, at 6:45 PM, Thomas Baumann wrote:
> confirmed, thanks for reporting.
> Carsten surely will checkin the following patch soon.
>
> Thomas
>
> diff --git a/lisp/org-bbdb.el b/lisp/org-bbdb.el
> index ad5265f..044b74b 100644
> --- a/lisp/org-bbdb.el
> +++ b/lisp/org-bbdb.el
> @@ -291,11 +291,16 @@ This is used by Org to re-create the
> anniversary hash table."
> (y (nth 2 date)) ; year
> (annivs (gethash (list m d) org-bbdb-anniv-hash))
> (text ())
> - split class form rec)
> + split class form rec recs)
>
> ;; we don't want to miss people born on Feb. 29th
> - (when (and (= m 3) (= d 1) (not (calendar-leap-year-p y)))
> - (setq annivs (cons annivs (gethash (list 2 29) org-bbdb-anniv-
> hash))))
> + (when (and (= m 3) (= d 1)
> + (not (null (gethash (list 2 29) org-bbdb-anniv-hash)))
> + (not (calendar-leap-year-p y)))
> + (setq recs (gethash (list 2 29) org-bbdb-anniv-hash))
> + (while (setq rec (pop recs))
> + (push rec annivs)))
> +
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: org-bbdb and 1. March
2008-10-06 16:45 ` Thomas Baumann
2008-10-06 18:45 ` Carsten Dominik
@ 2008-10-06 20:11 ` Tom Rauchenwald
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rauchenwald @ 2008-10-06 20:11 UTC (permalink / raw)
To: emacs-orgmode
Thomas Baumann <dtbaumann@yahoo.de> writes:
> confirmed, thanks for reporting.
> Carsten surely will checkin the following patch soon.
Works fine now, thanks for fixing this so quickly.
> Thomas
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-06 20:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-05 17:25 org-bbdb and 1. March Tom Rauchenwald
2008-10-06 16:45 ` Thomas Baumann
2008-10-06 18:45 ` Carsten Dominik
2008-10-06 20:11 ` Tom Rauchenwald
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).