* Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)]
@ 2013-11-05 11:57 Damien Cassou
2013-11-05 16:30 ` Bastien
0 siblings, 1 reply; 6+ messages in thread
From: Damien Cassou @ 2013-11-05 11:57 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
If you download and install org-pomodoro in your `org-modules' list, you
won't be able to report bugs with `org-submit-bug-report' anymore. The
problematic line in org-pomodoro is
(concat (file-name-directory load-file-name)
"/resources/bell.wav")
This line appears twice in org-pomodoro.el. It looks like the
`load-file-name' variable is nil in the context of
`org-submit-bug-report'.
Emacs : GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.8.4)
of 2013-10-03 on menkib, modified by Debian
Package: Org-mode version 8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)
current state:
==============
(setq
org-hide-leading-stars t
org-clock-clocked-in-display nil
org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
org-occur-hook '(org-first-headline-recenter)
org-imenu-depth 1
org-metaup-hook '(org-babel-load-in-session-maybe)
org-log-done 'time
org-confirm-shell-link-function 'yes-or-no-p
org-special-ctrl-a/e t
org-default-notes-file "tasks.org"
org-todo-keyword-faces '(("NEXT" :foreground "orange" :weight bold) ("CANCELLED" :foreground "forest green"))
org-after-todo-state-change-hook '(org-clock-out-if-current)
org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-babel-pre-tangle-hook '(save-buffer)
org-mode-hook '(#[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
#[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-refile-targets '(("tasks.org" :maxlevel . 2) ("someday.org" :maxlevel . 2) ("repeating.org" :level . 1))
org-fontify-done-headline t
org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
org-directory "~/Documents/configuration/org"
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-hide-inline-tasks org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-todo-keywords '((sequence "TODO(t)" "|" "DONE(d)" "CANCELLED(c)") (sequence "APPT(p)" "|" "DONE(d)" "CANCELED(c)")
(sequence "WAITING(w)" "|" "DONE(d)"))
org-time-stamp-rounding-minutes '(10 10)
org-modules '(org-bbdb org-bibtex org-docview org-gnus org-habit org-info org-jsinfo org-habit org-irc org-mew org-mhe org-protocol
org-rmail org-vm org-wl org-w3m org-bookmark org-publish)
org-confirm-elisp-link-function 'yes-or-no-p
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-completion-use-ido t
org-agenda-files '("~/Documents/configuration/org/tasks.org" "~/Documents/configuration/org/someday.org"
"~/Documents/configuration/org/repeating.org")
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)]
2013-11-05 11:57 Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)] Damien Cassou
@ 2013-11-05 16:30 ` Bastien
2013-11-05 16:36 ` Damien Cassou
0 siblings, 1 reply; 6+ messages in thread
From: Bastien @ 2013-11-05 16:30 UTC (permalink / raw)
To: Damien Cassou; +Cc: emacs-orgmode
Hi Damien,
Damien Cassou <damien.cassou@gmail.com> writes:
>
> If you download and install org-pomodoro in your `org-modules' list, you
> won't be able to report bugs with `org-submit-bug-report' anymore. The
> problematic line in org-pomodoro is
>
> (concat (file-name-directory load-file-name)
> "/resources/bell.wav")
This is a bug in org-pomodoro.el, better to report it to the author:
https://github.com/lolownia/org-pomodoro
Best,
--
Bastien
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)]
2013-11-05 16:30 ` Bastien
@ 2013-11-05 16:36 ` Damien Cassou
2013-11-05 16:53 ` Bastien
0 siblings, 1 reply; 6+ messages in thread
From: Damien Cassou @ 2013-11-05 16:36 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
On Tue, Nov 5, 2013 at 5:30 PM, Bastien <bzg@gnu.org> wrote:
> This is a bug in org-pomodoro.el, better to report it to the author:
> https://github.com/lolownia/org-pomodoro
I've just did: https://github.com/lolownia/org-pomodoro/issues/6
However, I'm not sure I agree with you.
--
Damien Cassou
http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without
losing enthusiasm."
Winston Churchill
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)]
2013-11-05 16:36 ` Damien Cassou
@ 2013-11-05 16:53 ` Bastien
2013-11-05 17:21 ` Damien Cassou
0 siblings, 1 reply; 6+ messages in thread
From: Bastien @ 2013-11-05 16:53 UTC (permalink / raw)
To: Damien Cassou; +Cc: emacs-orgmode
Hi Damien,
Damien Cassou <damien.cassou@gmail.com> writes:
> On Tue, Nov 5, 2013 at 5:30 PM, Bastien <bzg@gnu.org> wrote:
>> This is a bug in org-pomodoro.el, better to report it to the author:
>> https://github.com/lolownia/org-pomodoro
>
>
> I've just did: https://github.com/lolownia/org-pomodoro/issues/6
>
> However, I'm not sure I agree with you.
What do you mean exactly?
--
Bastien
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)]
2013-11-05 16:53 ` Bastien
@ 2013-11-05 17:21 ` Damien Cassou
2013-11-05 18:12 ` Bastien
0 siblings, 1 reply; 6+ messages in thread
From: Damien Cassou @ 2013-11-05 17:21 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
On Tue, Nov 5, 2013 at 5:53 PM, Bastien <bzg@altern.org> wrote:
>> However, I'm not sure I agree with you.
>
> What do you mean exactly?
I'm not sure this is a bug of org-pomodoro. I think org-pomodoro is
correct in its assumption that `load-file-name' is non-nil. Maybe it
is `org-submit-bug-report' that should pay attention to what it is
doing.
--
Damien Cassou
http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without
losing enthusiasm."
Winston Churchill
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)]
2013-11-05 17:21 ` Damien Cassou
@ 2013-11-05 18:12 ` Bastien
0 siblings, 0 replies; 6+ messages in thread
From: Bastien @ 2013-11-05 18:12 UTC (permalink / raw)
To: Damien Cassou; +Cc: emacs-orgmode
Damien Cassou <damien.cassou@gmail.com> writes:
> On Tue, Nov 5, 2013 at 5:53 PM, Bastien <bzg@altern.org> wrote:
>>> However, I'm not sure I agree with you.
>>
>> What do you mean exactly?
>
> I'm not sure this is a bug of org-pomodoro. I think org-pomodoro is
> correct in its assumption that `load-file-name' is non-nil.
Not in all circumstances.
-- Macro: defcustom option standard doc [keyword value]…
This macro declares OPTION as a user option (i.e., a customizable
variable). You should not quote OPTION.
The argument STANDARD is an expression that specifies the standard
value for OPTION. Evaluating the ‘defcustom’ form evaluates
STANDARD, but does not necessarily install the standard value. If
OPTION already has a default value, ‘defcustom’ does not change it.
If the user has saved a customization for OPTION, ‘defcustom’
installs the user’s customized value as OPTION’s default value. If
neither of those cases applies, ‘defcustom’ installs the result of
evaluating STANDARD as the default value.
The expression STANDARD can be evaluated at various other times,
too—whenever the customization facility needs to know OPTION’s
standard value. So be sure to use an expression which is harmless
to evaluate at any time.
The last sentence is the one important here.
Maybe org-pomodoro should use something like this:
(defcustom org-pomodoro-sound
"/resources/bell.wav"
"The path to a sound file that´s to be played when a pomodoro was finished."
:group 'org-pomodoro
:initialize 'custom-initialize-set
:set (lambda (var val)
(if load-file-name
(set-default
var (concat (file-name-directory load-file-name) "/resources/bell.wav"))
"/resources/bell.wav"))
:type 'file)
That way (get 'org-pomodoro-sound 'standard-value) would *always*
return something, which is the whole point.
Feel free to point to this suggestion when following up on github.
Best,
--
Bastien
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-05 18:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-05 11:57 Bug: Can't report org bugs when org-pomodoro is installed [8.2.1 (8.2.1-15-ge5cecc-elpaplus @ /home/cassou/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20131021/)] Damien Cassou
2013-11-05 16:30 ` Bastien
2013-11-05 16:36 ` Damien Cassou
2013-11-05 16:53 ` Bastien
2013-11-05 17:21 ` Damien Cassou
2013-11-05 18:12 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).