* [PATCH] Make html export honor html-viewport option
@ 2015-07-19 3:08 Richard Hoskins
2015-07-19 8:05 ` Nicolas Goaziou
0 siblings, 1 reply; 7+ messages in thread
From: Richard Hoskins @ 2015-07-19 3:08 UTC (permalink / raw)
To: emacs-orgmode
* ox-html.el (options-alist) Change html-viewport to honor
html-viewport: option in org file.
Value of `html-viewport' is being checked by `org-html--build-meta-info',
but it could not be changed due to its `options-alist' entry.
TINYCHANGE
---
lisp/ox-html.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 17695f0..bb0c258 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -163,7 +163,7 @@
(:html-use-infojs nil nil org-html-use-infojs)
(:html-use-unicode-chars nil nil org-html-use-unicode-chars)
(:html-validation-link nil nil org-html-validation-link)
- (:html-viewport nil nil org-html-viewport)
+ (:html-viewport nil "html-viewport" org-html-viewport)
(:html-inline-images nil nil org-html-inline-images)
(:html-table-attributes nil nil org-html-table-default-attributes)
(:html-table-row-tags nil nil org-html-table-row-tags)
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] Make html export honor html-viewport option
2015-07-19 3:08 [PATCH] Make html export honor html-viewport option Richard Hoskins
@ 2015-07-19 8:05 ` Nicolas Goaziou
2015-07-19 8:34 ` Richard Hoskins
0 siblings, 1 reply; 7+ messages in thread
From: Nicolas Goaziou @ 2015-07-19 8:05 UTC (permalink / raw)
To: Richard Hoskins; +Cc: emacs-orgmode
Hello,
Richard Hoskins <rich@walnutbeach.com> writes:
> * ox-html.el (options-alist) Change html-viewport to honor
> html-viewport: option in org file.
>
> Value of `html-viewport' is being checked by `org-html--build-meta-info',
> but it could not be changed due to its `options-alist' entry.
Thank you for the patch.
It can already be changed by customizing `org-html-viewport'. I don't
think it is useful to change it through OPTIONS keywords, as your patch
suggest, since the value is a bit complicated.
You may change it document wise using a BIND keyword.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Make html export honor html-viewport option
2015-07-19 8:05 ` Nicolas Goaziou
@ 2015-07-19 8:34 ` Richard Hoskins
2015-07-19 8:52 ` Rasmus
0 siblings, 1 reply; 7+ messages in thread
From: Richard Hoskins @ 2015-07-19 8:34 UTC (permalink / raw)
To: Richard Hoskins, emacs-orgmode
On Sun, Jul 19, 2015 at 4:05 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> It can already be changed by customizing `org-html-viewport'. I don't
> think it is useful to change it through OPTIONS keywords, as your patch
> suggest, since the value is a bit complicated.
>
> You may change it document wise using a BIND keyword.
You can't set it to nil through customize. I was trying to export html
without the viewport meta tags. Setting the customize variables to nil
just resulted in bogus viewport values.
I'll try using the BIND keyword.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Make html export honor html-viewport option
2015-07-19 8:34 ` Richard Hoskins
@ 2015-07-19 8:52 ` Rasmus
2015-07-20 7:03 ` Nicolas Goaziou
0 siblings, 1 reply; 7+ messages in thread
From: Rasmus @ 2015-07-19 8:52 UTC (permalink / raw)
To: emacs-orgmode
Richard Hoskins <rich@walnutbeach.com> writes:
> On Sun, Jul 19, 2015 at 4:05 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> It can already be changed by customizing `org-html-viewport'. I don't
>> think it is useful to change it through OPTIONS keywords, as your patch
>> suggest, since the value is a bit complicated.
>>
>> You may change it document wise using a BIND keyword.
>
> You can't set it to nil through customize. I was trying to export html
> without the viewport meta tags. Setting the customize variables to nil
> just resulted in bogus viewport values.
You are right you cannot set it to nil via Customize. If you do
(setq org-html-viewport nil)
you will not get a viewport.
Rasmus
--
Not everything that goes around comes back around, you know
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Make html export honor html-viewport option
2015-07-19 8:52 ` Rasmus
@ 2015-07-20 7:03 ` Nicolas Goaziou
2015-07-20 8:51 ` Rasmus
0 siblings, 1 reply; 7+ messages in thread
From: Nicolas Goaziou @ 2015-07-20 7:03 UTC (permalink / raw)
To: Rasmus; +Cc: emacs-orgmode
Rasmus <rasmus@gmx.us> writes:
> Richard Hoskins <rich@walnutbeach.com> writes:
>
>> On Sun, Jul 19, 2015 at 4:05 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>>> It can already be changed by customizing `org-html-viewport'. I don't
>>> think it is useful to change it through OPTIONS keywords, as your patch
>>> suggest, since the value is a bit complicated.
>>>
>>> You may change it document wise using a BIND keyword.
>>
>> You can't set it to nil through customize. I was trying to export html
>> without the viewport meta tags. Setting the customize variables to nil
>> just resulted in bogus viewport values.
>
> You are right you cannot set it to nil via Customize. If you do
> (setq org-html-viewport nil)
> you will not get a viewport.
I think we could offer the option to set it to nil via Customize. WDYT?
Regards,
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Make html export honor html-viewport option
2015-07-20 7:03 ` Nicolas Goaziou
@ 2015-07-20 8:51 ` Rasmus
2015-07-20 9:43 ` Nicolas Goaziou
0 siblings, 1 reply; 7+ messages in thread
From: Rasmus @ 2015-07-20 8:51 UTC (permalink / raw)
To: emacs-orgmode
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> I think we could offer the option to set it to nil via Customize. WDYT?
Of course, I'm just very slow at getting Customize right.
It's in 216a53d6cc88bd858fbc3aee82a2702a854fa8d6.
Richard: Is there any reason why you want to disable viewport? I added it
as it makes my own html pages look vastly better on the mobile. I don't
know much about HTML however.
Rasmus
--
The Kids call him Billy the Saint
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-07-20 9:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-19 3:08 [PATCH] Make html export honor html-viewport option Richard Hoskins
2015-07-19 8:05 ` Nicolas Goaziou
2015-07-19 8:34 ` Richard Hoskins
2015-07-19 8:52 ` Rasmus
2015-07-20 7:03 ` Nicolas Goaziou
2015-07-20 8:51 ` Rasmus
2015-07-20 9:43 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).