From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "José L. Doménech" <domenechjosel@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] An amended to the enhance Org babel for scheme blocks
Date: Mon, 24 Jul 2017 12:06:09 +0200 [thread overview]
Message-ID: <87tw22p2su.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87bmoas3ad.wl-domenechjosel@gmail.com> ("José L. Doménech"'s message of "Mon, 24 Jul 2017 09:27:22 +0200")
Hello,
"José L. Doménech" <domenechjosel@gmail.com> writes:
> No, but I don't know what is the preferred format for the entries. So
> instead of a patch i send the complete entries.
OK.
> ***** Scheme: new function: ~org-babel-scheme-table-or-string~
>
> New helper function to convert the return value from the scheme block
> to a table or a string.
I think this can be kept as an internal function, and named
`org-babel-scheme--table-or-string'.
> * lisp/ob-scheme.el (org-babel-scheme-null-to): New custom option that
> allows to use a empty list or null symbol to format the table
> output, initially assigned to 'hlines.
* lisp/ob-scheme.el (org-babel-scheme-null-to): New variable.
is sufficient in this case.
> (org-babel-scheme-table-or-string): New helper function to convert
> the return value from the block to a table or a string.
Likewise: "New function."
> +(defun org-babel-scheme-table-or-string (results)
Per above, I suggest to name it `org-babel-scheme--table-or-string' and
update the code accordingly.
I made the changes suggested above and added a "TINYCHANGE" cookie at
the end of the commit message since I don't know I you signed the FSF
papers already. I you haven't, please consider doing it.
Thank you!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-07-24 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 17:08 Enhance Org babel scheme "José L. Doménech"
2017-07-17 17:55 ` [PATCH] An amended to the enhance Org babel for scheme blocks "José L. Doménech"
2017-07-23 9:32 ` Nicolas Goaziou
2017-07-24 7:27 ` "José L. Doménech"
2017-07-24 10:06 ` Nicolas Goaziou [this message]
2017-07-24 10:44 ` "José L. Doménech"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw22p2su.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=domenechjosel@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).