From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] An amended to the enhance Org babel for scheme blocks
Date: Mon, 24 Jul 2017 12:06:09 +0200
Message-ID: <87tw22p2su.fsf@nicolasgoaziou.fr>
References: <87o9skwbrh.wl-domenechjosel@gmail.com>
	<87eftfq76z.wl-domenechjosel@gmail.com>
	<87pocrmrc1.fsf@nicolasgoaziou.fr>
	<87bmoas3ad.wl-domenechjosel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43265)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dZaFo-00026Q-Pv
	for emacs-orgmode@gnu.org; Mon, 24 Jul 2017 06:06:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dZaFj-0007ss-Rt
	for emacs-orgmode@gnu.org; Mon, 24 Jul 2017 06:06:20 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43505)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dZaFj-0007sB-Kj
	for emacs-orgmode@gnu.org; Mon, 24 Jul 2017 06:06:15 -0400
In-Reply-To: <87bmoas3ad.wl-domenechjosel@gmail.com> (=?utf-8?Q?=22Jos?=
	=?utf-8?Q?=C3=A9?= L. =?utf-8?Q?Dom=C3=A9nech=22's?=
	message of "Mon, 24 Jul 2017 09:27:22 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: =?utf-8?Q?Jos=C3=A9_L=2E_Dom=C3=A9nech?= <domenechjosel@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hello,

"Jos=C3=A9 L. Dom=C3=A9nech" <domenechjosel@gmail.com> writes:

> No, but I don't know what is the preferred format for the entries. So
> instead of a patch i send the complete entries.

OK.

> ***** Scheme: new function: ~org-babel-scheme-table-or-string~
>=20=20
>  New helper function to convert the return value from the scheme block
>  to a table or a string.

I think this can be kept as an internal function, and named
`org-babel-scheme--table-or-string'.

> * lisp/ob-scheme.el (org-babel-scheme-null-to): New custom option that
>   allows to use a empty list or null symbol to format the table
>   output, initially assigned to 'hlines.

  * lisp/ob-scheme.el (org-babel-scheme-null-to): New variable.

is sufficient in this case.

>   (org-babel-scheme-table-or-string): New helper function to convert
>   the return value from the block to a table or a string.

Likewise: "New function."

> +(defun org-babel-scheme-table-or-string (results)

Per above, I suggest to name it `org-babel-scheme--table-or-string' and
update the code accordingly.

I made the changes suggested above and added a "TINYCHANGE" cookie at
the end of the commit message since I don't know I you signed the FSF
papers already. I you haven't, please consider doing it.

Thank you!

Regards,

--=20
Nicolas Goaziou