From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Dale Sedivec <dale@codefu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Blank line when logging state changes [9.0.9 (9.0.9-692-gfbf31d.dirty-elpaplus @ /tmp/emacs/.emacs.d/elpa/org-plus-contrib-20170801/)]
Date: Tue, 01 Aug 2017 20:30:58 +0200 [thread overview]
Message-ID: <87tw1rqgwt.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAEj9N4J-M5_n+Dq4zK-+MoHZpXbA5KqQwCm4RivorP1HC_Pynw@mail.gmail.com> (Dale Sedivec's message of "Tue, 1 Aug 2017 11:27:05 -0500")
Hello,
Dale Sedivec <dale@codefu.org> writes:
> I think a recent change to org-split-string in master may have made logging
> of state changes a little uglier, adding "\\" and an empty line with
> trailing whitespace. Steps to reproduce:
>
[...]
> IMHO the new behavior of org-split-string actually seems correct to me
> (splitting a string should arguably never result in nil), so I've fixed
> this by patching org-store-log-note as demonstrated in the attached
> patch.
I agree the current behaviour is correct, since `org-split-string' does
not trim null strings. I applied a patch morally equivalent to yours.
Thank you for the report and the analysis.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-08-01 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 16:27 Bug: Blank line when logging state changes [9.0.9 (9.0.9-692-gfbf31d.dirty-elpaplus @ /tmp/emacs/.emacs.d/elpa/org-plus-contrib-20170801/)] Dale Sedivec
2017-08-01 18:30 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw1rqgwt.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=dale@codefu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).