From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: Blank line when logging state changes [9.0.9
 (9.0.9-692-gfbf31d.dirty-elpaplus @
 /tmp/emacs/.emacs.d/elpa/org-plus-contrib-20170801/)]
Date: Tue, 01 Aug 2017 20:30:58 +0200
Message-ID: <87tw1rqgwt.fsf@nicolasgoaziou.fr>
References: <CAEj9N4J-M5_n+Dq4zK-+MoHZpXbA5KqQwCm4RivorP1HC_Pynw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcbwf-0006Vz-Qn
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 14:31:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcbwd-0005Ue-Jn
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 14:31:05 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59576)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dcbwd-0005UA-Di
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 14:31:03 -0400
In-Reply-To: <CAEj9N4J-M5_n+Dq4zK-+MoHZpXbA5KqQwCm4RivorP1HC_Pynw@mail.gmail.com>
	(Dale Sedivec's message of "Tue, 1 Aug 2017 11:27:05 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Dale Sedivec <dale@codefu.org>
Cc: emacs-orgmode@gnu.org

Hello,

Dale Sedivec <dale@codefu.org> writes:

> I think a recent change to org-split-string in master may have made logging
> of state changes a little uglier, adding "\\" and an empty line with
> trailing whitespace.  Steps to reproduce:
>

[...]

> IMHO the new behavior of org-split-string actually seems correct to me
> (splitting a string should arguably never result in nil), so I've fixed
> this by patching org-store-log-note as demonstrated in the attached
> patch.

I agree the current behaviour is correct, since `org-split-string' does
not trim null strings. I applied a patch morally equivalent to yours.

Thank you for the report and the analysis.


Regards,

-- 
Nicolas Goaziou