From: James N V Cash <james.cash@occasionallycogent.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org, stig@brautaset.org
Subject: Re: tags-todo agenda shoud not ignore DONE items
Date: Tue, 15 Sep 2020 14:18:04 -0400 [thread overview]
Message-ID: <87tuvyaopv.fsf@gmail.com> (raw)
In-Reply-To: 87h7sbpk6v.fsf_-_@gnu.org \
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
Bastien <bzg@gnu.org> writes:
> Confirming this as an issue, if someone wants to fix it.
I've tried taking a shot at addressing this issue via the patch attached.
As mentioned in the thread, might potentially cause issues by changing how it matches -- should there be an option? Or is the idea just that if you really do want to exclude done tags, you'd query like "/!DONE"?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: matcher allow all tags --]
[-- Type: text/x-diff, Size: 551 bytes --]
diff --git a/lisp/org.el b/lisp/org.el
index 020cfc873..3db1add8b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11691,7 +11691,7 @@ See also `org-scan-tags'."
`(and ,tagsmatcher ,todomatcher)
(or tagsmatcher todomatcher t))))
(when org--matcher-tags-todo-only
- (setq matcher `(and (member todo org-not-done-keywords) ,matcher)))
+ (setq matcher `(and (member todo org-todo-keywords-1) ,matcher)))
(cons match0 `(lambda (todo tags-list level) ,matcher)))))
(defun org--tags-expand-group (group tag-groups expanded)
next reply other threads:[~2020-09-16 4:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:18 James N V Cash [this message]
2020-11-13 6:22 ` tags-todo agenda shoud not ignore DONE items Kyle Meyer
2021-04-27 19:39 ` Bastien
-- strict thread matches above, loose matches on Subject: below --
2020-06-13 14:40 tags-todo org-agenda-custom-command weirdness Stig Brautaset
2020-06-15 3:16 ` Kyle Meyer
2020-06-15 18:52 ` Stig Brautaset
2020-06-16 5:11 ` Kyle Meyer
2020-09-06 5:07 ` tags-todo agenda shoud not ignore DONE items (was: tags-todo org-agenda-custom-command weirdness) Bastien
2021-05-16 22:56 ` tags-todo agenda shoud not ignore DONE items Bastien
2021-05-17 4:46 ` Kyle Meyer
2021-05-17 5:24 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuvyaopv.fsf@gmail.com \
--to=james.cash@occasionallycogent.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=stig@brautaset.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).