emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: David Maus <dmaus@ictsoc.de>
To: Hans-Peter Deifel <hpdeifel@gmx.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Custom agenda and DONE faces
Date: Sun, 18 Mar 2012 18:02:32 +0100	[thread overview]
Message-ID: <87sjh5266v.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <87r4xwypxh.fsf@hpdeifel.de>

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi Hans-Peter,

At Wed, 15 Feb 2012 18:19:54 +0100,
Hans-Peter Deifel wrote:
>
> Hi all,
>
> [...]
>
> I played around in the source code and noticed that the following patch fixes
> the problem, but I don't know the code base well enough to understand why it
> works and what other implications it might have:
>
> [...]

I've applied a fix for this problem to master. Your patch did the
right thing; `org-prepare-agenda' was called by `org-agenda-list'
which already set up the done-keywords. But when `org-agenda-list' was
called in a block agenda `org-prepare-agenda' set the variable to nil
and left early.

Best and thanks,
  -- David

[-- Attachment #2: OpenPGP Digital Signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

      reply	other threads:[~2012-03-18 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 17:19 Hans-Peter Deifel
2012-03-18 17:02 ` David Maus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjh5266v.wl%dmaus@ictsoc.de \
    --to=dmaus@ictsoc.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=hpdeifel@gmx.de \
    --subject='Re: Custom agenda and DONE faces' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).