From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Custom agenda and DONE faces Date: Sun, 18 Mar 2012 18:02:32 +0100 Message-ID: <87sjh5266v.wl%dmaus@ictsoc.de> References: <87r4xwypxh.fsf@hpdeifel.de> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.6 - "Maruoka") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Sun_Mar_18_18:02:29_2012-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:58426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9JV9-0007iu-Gb for emacs-orgmode@gnu.org; Sun, 18 Mar 2012 13:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9JV6-0005IA-69 for emacs-orgmode@gnu.org; Sun, 18 Mar 2012 13:02:39 -0400 Received: from app1a.xlhost.de ([213.202.242.161]:43739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9JV6-0005Hs-03 for emacs-orgmode@gnu.org; Sun, 18 Mar 2012 13:02:36 -0400 In-Reply-To: <87r4xwypxh.fsf@hpdeifel.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Hans-Peter Deifel Cc: emacs-orgmode@gnu.org --pgp-sign-Multipart_Sun_Mar_18_18:02:29_2012-1 Content-Type: text/plain; charset=US-ASCII Hi Hans-Peter, At Wed, 15 Feb 2012 18:19:54 +0100, Hans-Peter Deifel wrote: > > Hi all, > > [...] > > I played around in the source code and noticed that the following patch fixes > the problem, but I don't know the code base well enough to understand why it > works and what other implications it might have: > > [...] I've applied a fix for this problem to master. Your patch did the right thing; `org-prepare-agenda' was called by `org-agenda-list' which already set up the done-keywords. But when `org-agenda-list' was called in a block agenda `org-prepare-agenda' set the variable to nil and left early. Best and thanks, -- David --pgp-sign-Multipart_Sun_Mar_18_18:02:29_2012-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit Content-Description: OpenPGP Digital Signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAk9mFSUACgkQDMLgk1Evc4VYHAD7BrzY4BTB8A2fGaYYq3rJF2IM +QneRLmoFZFb76OMNLcA/iIGESoQqOQWfGzu1GNFJcxfQLBc7fLBKSuA754Tf0M7 =YuSQ -----END PGP SIGNATURE----- --pgp-sign-Multipart_Sun_Mar_18_18:02:29_2012-1--