From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Ryo TAKAISHI <ryo.takaishi.0@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Capture: Expand keyword within %(SEXP) in template
Date: Sat, 03 Nov 2012 09:45:01 +0100 [thread overview]
Message-ID: <87sj8rgjn6.fsf@gmail.com> (raw)
In-Reply-To: <87lieknhjy.fsf@gmail.com> (Ryo TAKAISHI's message of "Sat, 03 Nov 2012 00:36:01 +0900")
Hello,
> I fix these problem. A new patch expand keyword recursively, and only
> symbol.
Great.
> + (let* ((sexp (mapcar 'org-capture-expand-keyword-in-embedded-elisp
> + (read (current-buffer))))
> + (result (org-eval sexp)))
> (delete-region template-start (point))
> (insert result))))))
>
> +(defun org-capture-expand-keyword-in-embedded-elisp (attr)
> + (cond ((consp attr)
> + (mapcar 'org-capture-expand-keyword-in-embedded-elisp attr))
> + ((symbolp attr)
> + (let* ((attr-symbol (symbol-name attr))
> + (key (and (string-match "%\\(:.*\\)" attr-symbol)
> + (intern (match-string 1 attr-symbol)))))
> + (or (plist-get org-store-link-plist key)
> + attr)))
> + (t attr)))
The code looks good, although I would have moved the external `mapcar'
within the worker function in order to make its purpose clearer.
Also, would you mind to provide a docstring for the function? Something
along the lines of:
"Recursively replace capture link keywords in ATTR sexp.
Such keywords are prefixed with "%:". See `org-capture-template' for
more information."
You may also want to rename it
`org-capture--expand-keyword-in-embedded-elisp' to insist on the fact it
is an internal function. That's not mandatory, though.
Finally, this feature must be documented in `org-capture-templates'
docstring and org.texi.
Thank you for working on it.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2012-11-03 8:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 9:20 [PATCH] Capture: Expand keyword within %(SEXP) in template Ryo TAKAISHI
2012-11-02 11:50 ` Nicolas Goaziou
2012-11-02 13:55 ` Ryo TAKAISHI
2012-11-02 14:11 ` Nicolas Goaziou
2012-11-02 15:36 ` Ryo TAKAISHI
2012-11-03 8:45 ` Nicolas Goaziou [this message]
2012-11-04 7:51 ` Ryo TAKAISHI
2012-11-04 13:10 ` Nicolas Goaziou
2012-11-04 15:05 ` Ryo TAKAISHI
2012-11-05 0:38 ` Nicolas Goaziou
2012-11-05 12:34 ` Ryo TAKAISHI
2012-11-05 12:39 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj8rgjn6.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ryo.takaishi.0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).