emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ryo TAKAISHI <ryo.takaishi.0@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Capture: Expand keyword within %(SEXP) in template
Date: Mon, 05 Nov 2012 21:34:45 +0900	[thread overview]
Message-ID: <87zk2w2pp6.fsf@gmail.com> (raw)
In-Reply-To: <87wqy0eveh.fsf@gmail.com> (Nicolas Goaziou's message of "Mon, 05 Nov 2012 01:38:30 +0100")

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Hello,

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Hello,
>
> Ryo TAKAISHI <ryo.takaishi.0@gmail.com> writes:
>
>> I create a complete patch for current commit.
>
> I've pushed your patch on master (with some documentation tweaks). Thank
> you for your work.

Thank you very much.
But, I had forgot to escape double quote in docstring, so attach patch
fixing it.

> Also, please consider signing FSF papers if you want to make other
> contributions to Org.

OK, I want to consider when I send a patch next time.

Regards,
Ryo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-capture-Fix-a-docstring.patch --]
[-- Type: text/x-patch, Size: 940 bytes --]

From dacf4ef0677f80cfc589bf5014ca71dfdd2dc3d4 Mon Sep 17 00:00:00 2001
From: Ryo TAKAISHI <ryo.takaishi.0@gmail.com>
Date: Mon, 5 Nov 2012 21:20:14 +0900
Subject: [PATCH] org-capture: Fix a docstring

* lisp/org-capture.el: Fix a docstring.

TINYCHANGE
---
 lisp/org-capture.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 695c5eb..ccdb0c1 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -1631,7 +1631,7 @@ The template may still contain \"%?\" for cursor positioning."
 
 (defun org-capture--expand-keyword-in-embedded-elisp (attr)
   "Recursively replace capture link keywords in ATTR sexp.
-Such keywords are prefixed with "%:".  See `org-capture-template'
+Such keywords are prefixed with '%:'.  See `org-capture-template'
 for more information."
   (cond ((consp attr)
 	 (mapcar 'org-capture--expand-keyword-in-embedded-elisp attr))
-- 
1.7.9.5


  reply	other threads:[~2012-11-05 12:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  9:20 [PATCH] Capture: Expand keyword within %(SEXP) in template Ryo TAKAISHI
2012-11-02 11:50 ` Nicolas Goaziou
2012-11-02 13:55   ` Ryo TAKAISHI
2012-11-02 14:11     ` Nicolas Goaziou
2012-11-02 15:36       ` Ryo TAKAISHI
2012-11-03  8:45         ` Nicolas Goaziou
2012-11-04  7:51           ` Ryo TAKAISHI
2012-11-04 13:10             ` Nicolas Goaziou
2012-11-04 15:05               ` Ryo TAKAISHI
2012-11-05  0:38                 ` Nicolas Goaziou
2012-11-05 12:34                   ` Ryo TAKAISHI [this message]
2012-11-05 12:39                     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk2w2pp6.fsf@gmail.com \
    --to=ryo.takaishi.0@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).