emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Make `org-contacts-message-complete-function' work with byte compilation
Date: Sun, 10 Mar 2013 02:25:08 +0100	[thread overview]
Message-ID: <87sj449hcb.fsf@ft.bewatermyfriend.org> (raw)

Without this patch (when I am _byte-compiling_ org-contacts.el), I am
getting error messages like this (when attempting address completion via
`completion-at-point' and `org-contacts-message-complete-function'):

    Symbol's function definition is void: remove-duplicates
    Symbol's function definition is void: some

With this patch, it seems to be working as expected.
---

Disclaimer: I'm no Elisp expert. Maybe this should be solved
differently.

 contrib/lisp/org-contacts.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index ab44a7b..ac5ff6d 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -36,10 +36,8 @@
 ;;
 ;;; Code:
 
-(eval-when-compile
-  (require 'cl))
-
 (eval-and-compile
+  (require 'cl)
   (require 'org))
 (require 'gnus-util)
 (require 'gnus-art)
-- 
1.8.2.rc1

             reply	other threads:[~2013-03-10  1:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  1:25 Frank Terbeck [this message]
2013-03-10 23:24 ` [PATCH] Make `org-contacts-message-complete-function' work with byte compilation Daimrod
2013-03-11  6:48   ` Achim Gratz
2013-03-11  9:21     ` Daimrod
2013-03-11 13:48       ` Frank Terbeck
2013-03-11 15:55       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sj449hcb.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).