emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make `org-contacts-message-complete-function' work with byte compilation
Date: Mon, 11 Mar 2013 14:48:04 +0100	[thread overview]
Message-ID: <87ip4yavzf.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <87wqtemgv0.fsf@tanger.home> (daimrod@gmail.com's message of "Mon, 11 Mar 2013 10:21:39 +0100")

Daimrod wrote:
> Achim Gratz <Stromeko@nexgo.de> writes:
>> Daimrod writes:
>>> @All: Can I use (require 'cl) and ignore the warning or is there better
>>> solution?
>>
>> You could if this would never go into mainline, where it is not allowed
>> due to the namespace pollution that cl causes.  You could use cl-lib
>> instead, but then this would be an Emacs-24 only solution.  In general,
>> the stanza ((eval-when-compile (require 'cl)) only works as intended
>> when you are only using cl macros, but you seem to use defuns.  You
>> could check how hard it is to replace these with plain elisp, aside from
>> syntactical inconveniences this is usually not a big problem.
>
> I've done this, thanks for the advice.


I've just given the latest git HEAD version a spin and it seems to work
as expected. Thanks for taking an interesting and fixing this so
promptly. ;)


Regards, Frank

  reply	other threads:[~2013-03-11 13:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  1:25 [PATCH] Make `org-contacts-message-complete-function' work with byte compilation Frank Terbeck
2013-03-10 23:24 ` Daimrod
2013-03-11  6:48   ` Achim Gratz
2013-03-11  9:21     ` Daimrod
2013-03-11 13:48       ` Frank Terbeck [this message]
2013-03-11 15:55       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip4yavzf.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).