From: Bastien <firstname.lastname@example.org>
To: Nicolas Richard <email@example.com>
Subject: Re: Bug: TAB cycling and narrowing to subtree [8.2.6 (release_8.2.6-903-ga1b4d9 @ /home/youngfrog/sources/org-mode/lisp/)]
Date: Fri, 23 May 2014 13:14:31 +0200 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
In-Reply-To: <email@example.com> (Nicolas Richard's message of "Fri, 23 May 2014 10:56:00 +0200")
Nicolas Richard <firstname.lastname@example.org> writes:
> e.g. why does the advice exist in the first place ?
No real reason, I removed it.
> IIUC, org-end-of-subtree exists for speed reasons. Could we move the
> advice to within org-end-of-subtree itself, i.e. something like:
> (defun org-end-of-subtree (...)
> (if (derived-mode-p 'org-mode)
> (progn existing code)
This would slow down `org-end-of-subtree'. Instead, I simply removed
calls to `outline-end-of-subtree' and replaced it with appropriate
calls to `org-end-of-subtree'.
> Anyway, looking at the functions that get called, I spotted an easy fix.
> WDYT ?
I think it's good! I applied the patch, thanks for digging into this,
probably the psychological/technical support I needed to move forward
prev parent reply other threads:[~2014-05-23 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 10:12 Bug: TAB cycling and narrowing to subtree [8.2.6 (release_8.2.6-903-ga1b4d9 @ /home/youngfrog/sources/org-mode/lisp/)] Nicolas Richard
2014-05-23 5:54 ` Bastien
2014-05-23 8:56 ` Nicolas Richard
2014-05-23 11:14 ` Bastien [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).