From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: Bug: TAB cycling and narrowing to subtree [8.2.6
 (release_8.2.6-903-ga1b4d9 @ /home/youngfrog/sources/org-mode/lisp/)]
Date: Fri, 23 May 2014 13:14:31 +0200
Message-ID: <87sio0aaiy.fsf@bzg.ath.cx>
References: <87a9b3xh1n.fsf@geodiff-mac3.ulb.ac.be>
	<87oaypf39t.fsf@bzg.ath.cx> <87lhtsx49r.fsf@yahoo.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WnpXX-00066o-Ju
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 09:29:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WnpXR-0002bS-5S
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 09:29:39 -0400
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:56926)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WnpXQ-0002bG-Td
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 09:29:33 -0400
Received: by mail-wi0-f181.google.com with SMTP id n15so875859wiw.2
	for <emacs-orgmode@gnu.org>; Fri, 23 May 2014 06:29:31 -0700 (PDT)
In-Reply-To: <87lhtsx49r.fsf@yahoo.fr> (Nicolas Richard's message of "Fri, 23
	May 2014 10:56:00 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Cc: emacs-orgmode@gnu.org

Hi Nicolas,

Nicolas Richard <theonewiththeevillook@yahoo.fr> writes:

> e.g. why does the advice exist in the first place ?

No real reason, I removed it.

> IIUC, org-end-of-subtree exists for speed reasons. Could we move the
> advice to within org-end-of-subtree itself, i.e. something like:
>
> (defun org-end-of-subtree (...)
>    (if (derived-mode-p 'org-mode)
>        (progn existing code)
>      (outline-end-of-subtree)))

This would slow down `org-end-of-subtree'.  Instead, I simply removed
calls to `outline-end-of-subtree' and replaced it with appropriate
calls to `org-end-of-subtree'.

> Anyway, looking at the functions that get called, I spotted an easy fix.
> WDYT ?

I think it's good!  I applied the patch, thanks for digging into this,
probably the psychological/technical support I needed to move forward
on this.

Best,

-- 
 Bastien