* BUG: org-block face not working
@ 2015-04-28 9:28 Michal Koval
2015-04-28 20:06 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Michal Koval @ 2015-04-28 9:28 UTC (permalink / raw)
To: emacs-orgmode
Hello,
recently I switched from maint to master (release_8.3beta-1091-g96c533)
and noticed that org-block face defined in my theme does not work anymore.
What could be of some help is that when I type <s TAB, I see a code block
#+BEGIN_SRC
#+END_SRC
with the correct background face in the block specified in my theme.
But, when I type in a language (typing one non-blank character after
BEGIN_SRC is enough), the face inside the block changes to the Emacs
default one.
e.g.
#+BEGIN_SRC python
#+END_SRC
I got the same behavior with emacs -q.
Regards,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: org-block face not working
2015-04-28 9:28 BUG: org-block face not working Michal Koval
@ 2015-04-28 20:06 ` Nicolas Goaziou
2015-04-29 5:44 ` Michal Koval
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2015-04-28 20:06 UTC (permalink / raw)
To: Michal Koval; +Cc: emacs-orgmode
Hello,
Michal Koval <koval.miso@gmail.com> writes:
> recently I switched from maint to master (release_8.3beta-1091-g96c533)
> and noticed that org-block face defined in my theme does not work anymore.
>
> What could be of some help is that when I type <s TAB, I see a code block
> #+BEGIN_SRC
>
> #+END_SRC
>
> with the correct background face in the block specified in my theme.
> But, when I type in a language (typing one non-blank character after
> BEGIN_SRC is enough), the face inside the block changes to the Emacs
> default one.
> e.g.
> #+BEGIN_SRC python
>
> #+END_SRC
I don't think src blocks ever got `org-block' face. There used to be
a `org-block-background' face for an overlay, however, but it was
removed in commit f8b42e8ebeeecdef59a8a7cbc4324264a5162197.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: org-block face not working
2015-04-28 20:06 ` Nicolas Goaziou
@ 2015-04-29 5:44 ` Michal Koval
2015-04-29 10:26 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Michal Koval @ 2015-04-29 5:44 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
Hello,
On 04/28/15 22:06 PM, Nicolas Goaziou wrote:
> Hello,
>
> Michal Koval <koval.miso@gmail.com> writes:
>
>> recently I switched from maint to master (release_8.3beta-1091-g96c533)
>> and noticed that org-block face defined in my theme does not work anymore.
>
> I don't think src blocks ever got `org-block' face. There used to be
> a `org-block-background' face for an overlay, however, but it was
> removed in commit f8b42e8ebeeecdef59a8a7cbc4324264a5162197.
>
I see `(defface org-block' in org-faces.el and I see it used it in org.el
`org-fontify-meta-lines-and-blocks-1' where the bug probably is.
Best regards,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: org-block face not working
2015-04-29 5:44 ` Michal Koval
@ 2015-04-29 10:26 ` Nicolas Goaziou
2015-04-29 15:41 ` Michal Koval
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2015-04-29 10:26 UTC (permalink / raw)
To: Michal Koval; +Cc: emacs-orgmode
Michal Koval <koval.miso@gmail.com> writes:
> I see `(defface org-block' in org-faces.el and I see it used it in org.el
> `org-fontify-meta-lines-and-blocks-1' where the bug probably is.
`org-block' face is used for verbatim blocks (e.g, example block) and
src blocks without a language specified. If language is specified,
fontification mechanism is done with `org-src-font-lock-fontify-block',
which doesn't use `org-block' face.
It was already the case in maint.
Regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: org-block face not working
2015-04-29 10:26 ` Nicolas Goaziou
@ 2015-04-29 15:41 ` Michal Koval
0 siblings, 0 replies; 5+ messages in thread
From: Michal Koval @ 2015-04-29 15:41 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
On 04/29/15 12:26 PM, Nicolas Goaziou wrote:
> Michal Koval <koval.miso@gmail.com> writes:
>
>> I see `(defface org-block' in org-faces.el and I see it used it in org.el
>> `org-fontify-meta-lines-and-blocks-1' where the bug probably is.
>
> `org-block' face is used for verbatim blocks (e.g, example block) and
> src blocks without a language specified. If language is specified,
> fontification mechanism is done with `org-src-font-lock-fontify-block',
> which doesn't use `org-block' face.
>
> It was already the case in maint.
I have just tried the latest maint version and it works as I described
in my first mail. The background specified in `org-block' is applied to
the language named begin_src blocks, too. The language specific
fontification of the foreground faces is applied as well. I really like
the feature.
In the master branch it works only for unnamed begin_src blocks (and
quote, verbatim, and example).
I like the behavior of the maint better, but in case that `org-block'
was really meant to apply only to unnamed src blocks + quote, verbatim
and example, please change the documentation string of the `org-block'
from "Face text in #+begin ... #+end blocks." to something more
descriptive.
Is it possible to change the background of the src blocks in a different
way?
Thank you,
best regards,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-29 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-28 9:28 BUG: org-block face not working Michal Koval
2015-04-28 20:06 ` Nicolas Goaziou
2015-04-29 5:44 ` Michal Koval
2015-04-29 10:26 ` Nicolas Goaziou
2015-04-29 15:41 ` Michal Koval
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).