From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: emacs-orgmode@gnu.org, Frederick Giasson <fred@fgiasson.com>
Subject: Re: Table (used a "spreadsheet") org-sbe issues when the value is a string
Date: Thu, 07 Sep 2017 18:04:01 +0200 [thread overview]
Message-ID: <87shfyxzpq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87a826mt55.fsf@linaro.org> ("Alex Bennée"'s message of "Thu, 07 Sep 2017 16:21:26 +0100")
Alex Bennée <alex.bennee@linaro.org> writes:
> So more correctly when org-confirm-babel-evaluate is set it breaks due
> to info not containing a character position for the TBLFM code. I fixed
> this by patching org-babel-check-confirm-evaluate:
>
> modified lisp/ob-core.el
> @@ -242,7 +242,8 @@ should be asked whether to allow evaluation."
> (and export (equal eval "query-export"))
> (if (functionp org-confirm-babel-evaluate)
> (save-excursion
> - (goto-char (nth 5 info))
> + (when (nth 5 info)
> + (goto-char (nth 5 info)))
> (funcall org-confirm-babel-evaluate
> ;; language, code block body
> (nth 0 info) (nth 1 info)))
>
> I'm not sure the goto-char is legitimate anyway as the documentation for
> org-confirm-babel-evaluate says nothing about point being set while it
> executes.
I agree and removed `goto-char'. Thank you for the analysis and the
patch.
Regards,
prev parent reply other threads:[~2017-09-07 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 12:37 Table (used a "spreadsheet") org-sbe issues when the value is a string Frederick Giasson
2016-06-22 23:06 ` Nicolas Goaziou
2017-09-06 15:32 ` Alex Bennée
2017-09-06 16:14 ` Nicolas Goaziou
2017-09-06 21:46 ` Alex Bennée
2017-09-07 15:21 ` Alex Bennée
2017-09-07 16:04 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shfyxzpq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=alex.bennee@linaro.org \
--cc=emacs-orgmode@gnu.org \
--cc=fred@fgiasson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).