emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: stardiviner <numbchild@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: A recent fix caused other face highlighting issue
Date: Thu, 30 May 2019 15:22:37 +0200	[thread overview]
Message-ID: <87sgswjcv6.fsf@gmail.com> (raw)
In-Reply-To: <87ftow9lrf.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Thu, 30 May 2019 14:20:36 +0200")

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> This commit "42abf5c6954dee8410e33d0c5140d3b36c9d1c15" try to fix
>> org-do-emphasis-faces function on strike-through fontification on heading. But
>> it failed on verbatim like ~code~, =verbatim= etc. Can it be reverted? or provide
>> another solution?
>
> I reverted the commit. I Cc'ed Kévin, as the author of the patch.
>
> Regards,

Hi!

Thanks for the revert; as I mentioned in the previous discussion[1], my
patch was more of a workaround anyway.  Stefan Monnier committed a
proper fix in bug#35476, so strike-through will work with headings on
Emacs 27.

[1] http://lists.gnu.org/archive/html/emacs-orgmode/2019-04/msg00236.html

      reply	other threads:[~2019-05-30 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29  0:51 A recent fix caused other face highlighting issue stardiviner
2019-05-30 12:20 ` Nicolas Goaziou
2019-05-30 13:22   ` Kévin Le Gouguec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgswjcv6.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=numbchild@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).