* A recent fix caused other face highlighting issue
@ 2019-05-29 0:51 stardiviner
2019-05-30 12:20 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: stardiviner @ 2019-05-29 0:51 UTC (permalink / raw)
To: org-mode-email
This commit "42abf5c6954dee8410e33d0c5140d3b36c9d1c15" try to fix
org-do-emphasis-faces function on strike-through fontification on heading. But
it failed on verbatim like ~code~, =verbatim= etc. Can it be reverted? or provide
another solution?
--
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: A recent fix caused other face highlighting issue
2019-05-29 0:51 A recent fix caused other face highlighting issue stardiviner
@ 2019-05-30 12:20 ` Nicolas Goaziou
2019-05-30 13:22 ` Kévin Le Gouguec
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2019-05-30 12:20 UTC (permalink / raw)
To: stardiviner; +Cc: org-mode-email, Kévin Le Gouguec
Hello,
stardiviner <numbchild@gmail.com> writes:
> This commit "42abf5c6954dee8410e33d0c5140d3b36c9d1c15" try to fix
> org-do-emphasis-faces function on strike-through fontification on heading. But
> it failed on verbatim like ~code~, =verbatim= etc. Can it be reverted? or provide
> another solution?
I reverted the commit. I Cc'ed Kévin, as the author of the patch.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: A recent fix caused other face highlighting issue
2019-05-30 12:20 ` Nicolas Goaziou
@ 2019-05-30 13:22 ` Kévin Le Gouguec
0 siblings, 0 replies; 3+ messages in thread
From: Kévin Le Gouguec @ 2019-05-30 13:22 UTC (permalink / raw)
To: stardiviner; +Cc: org-mode-email
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> This commit "42abf5c6954dee8410e33d0c5140d3b36c9d1c15" try to fix
>> org-do-emphasis-faces function on strike-through fontification on heading. But
>> it failed on verbatim like ~code~, =verbatim= etc. Can it be reverted? or provide
>> another solution?
>
> I reverted the commit. I Cc'ed Kévin, as the author of the patch.
>
> Regards,
Hi!
Thanks for the revert; as I mentioned in the previous discussion[1], my
patch was more of a workaround anyway. Stefan Monnier committed a
proper fix in bug#35476, so strike-through will work with headings on
Emacs 27.
[1] http://lists.gnu.org/archive/html/emacs-orgmode/2019-04/msg00236.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-30 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 0:51 A recent fix caused other face highlighting issue stardiviner
2019-05-30 12:20 ` Nicolas Goaziou
2019-05-30 13:22 ` Kévin Le Gouguec
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).