emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Tim Cross <theophilusx@gmail.com>,
	org-mode list <emacs-orgmode@gnu.org>,
	Christian Moe <mail@christianmoe.com>
Subject: Re: Free up C-c SPC/org-table-blank-field?
Date: Thu, 04 Mar 2021 11:49:44 -0800	[thread overview]
Message-ID: <87sg5a66nb.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <CADn3Z2LUsB2je1BMFDQEdX6+2CrFEj-sMS4nNEs4_6SS9tMrdQ@mail.gmail.com> (Carsten Dominik's message of "Thu, 11 Feb 2021 10:45:08 +0100")

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> On Fri, Feb 5, 2021 at 7:33 PM Eric Abrahamsen <eric@ericabrahamsen.net>
> wrote:
>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>> > On Fri, Feb 5, 2021 at 11:13 AM Christian Moe <mail@christianmoe.com>
>> wrote:
>> >
>> >>
>> >> Tim Cross writes:
>> >>
>> >> > Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>> >> >
>> >> >>> Does it actually need a key binding? I've never used it and just use
>> >> >>> <tab> to move to the next field, leaving the field blank.
>> >> >>
>> >> >> I assume it's meant for blanking a field you've already typed
>> something
>> >> >> into. But yes, I can't imagine it's a heavily-used command, and I
>> >> >> suspect the C-c <SPC> binding is mostly mnemonic: "make this field
>> >> >> contain only blanks".
>> >> >>
>> >> >
>> >> > I guess that makes sense, but not convinced the use of a valuable key
>> >> > binding is justified given the need. Then again, others probably have
>> >> > vastly different use cases to mine.
>> >>
>> >> One can also blank a field by pressing <SPC> immediately after tabbing
>> >> into it. So C-c <SPC> isn't strictly needed.
>> >>
>> >
>> > Hi,
>> >
>> > I think there would be minimal impact from releasing this key binding.
>> So
>> > I think we could remove it.
>>
>> Well that would be pretty nice, if you don't think it would be too
>> disruptive. Shall I prepare a patch?
>>
>
> I am not taking the decisions, but I would say: yes, please do.

That took a while, for such a simple patch! Hope this is acceptable.

Thanks,
Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Remove-default-binding-for-org-table-blank-field.patch --]
[-- Type: text/x-patch, Size: 1472 bytes --]

From c7d246b20f56bcc89a23d523ebf64a2f67c58bc6 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Thu, 4 Mar 2021 11:44:12 -0800
Subject: [PATCH] Remove default binding for org-table-blank-field

* lisp/org-keys.el: The command isn't useful enough to occupy such a
useful keybinding as "C-c SPC".
---
 lisp/org-keys.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lisp/org-keys.el b/lisp/org-keys.el
index f0fdb79ea..07ff85349 100644
--- a/lisp/org-keys.el
+++ b/lisp/org-keys.el
@@ -174,7 +174,6 @@
 (declare-function org-show-subtree "org" ())
 (declare-function org-sort "org" (&optional with-case))
 (declare-function org-sparse-tree "org" (&optional arg type))
-(declare-function org-table-blank-field "org" ())
 (declare-function org-table-copy-down "org" (n))
 (declare-function org-table-create-or-convert-from-region "org" (arg))
 (declare-function org-table-create-with-table\.el "org-table" ())
@@ -620,7 +619,6 @@ COMMANDS is a list of alternating OLDDEF NEWDEF command names."
 (org-defkey org-mode-map (kbd "RET") #'org-return)
 (org-defkey org-mode-map (kbd "C-j") #'org-return-and-maybe-indent)
 (org-defkey org-mode-map (kbd "C-c ?") #'org-table-field-info)
-(org-defkey org-mode-map (kbd "C-c SPC") #'org-table-blank-field)
 (org-defkey org-mode-map (kbd "C-c +") #'org-table-sum)
 (org-defkey org-mode-map (kbd "C-c =") #'org-table-eval-formula)
 (org-defkey org-mode-map (kbd "C-c '") #'org-edit-special)
-- 
2.30.1


  reply	other threads:[~2021-03-04 19:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 18:05 Eric Abrahamsen
2021-02-03  6:16 ` Kyle Meyer
2021-02-03  6:26   ` Tim Cross
2021-02-05  3:48   ` Eric Abrahamsen
2021-02-05  4:45     ` Kyle Meyer
2021-02-05  5:32     ` Tim Cross
2021-02-05  9:41       ` Christian Moe
2021-02-05 10:44         ` Carsten Dominik
2021-02-05 18:33           ` Eric Abrahamsen
2021-02-11  9:45             ` Carsten Dominik
2021-03-04 19:49               ` Eric Abrahamsen [this message]
2021-04-28  3:50                 ` Bastien
2021-05-01 21:09                   ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg5a66nb.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@christianmoe.com \
    --cc=theophilusx@gmail.com \
    --subject='Re: Free up C-c SPC/org-table-blank-field?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).