From: Bastien <email@example.com> To: Kyle Meyer <firstname.lastname@example.org> Cc: "Dr. Arne Babenhauserheide" <email@example.com>, firstname.lastname@example.org Subject: Re: Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)] Date: Fri, 30 Apr 2021 09:04:55 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (Kyle Meyer's message of "Sun, 10 Jan 2021 23:08:02 GMT") Hi Kyle and Arne, Kyle Meyer <email@example.com> writes: > I'm not an ox-rss user and don't know if there are more realistic ways > to hit this error, but I was able to trigger it by taking an already > exported buffer of > > * h1 > :PROPERTIES: > :ID: 76841adc-b233-4f6d-8446-3478f263544b > :PUBDATE: <2021-01-10 Sun 17:46> > :END: > > and then setting PUBDATE to an empty string and exporting again. > > I'm not sure if the error you see is indicative of a larger issue, > though either way guarding against an empty string as your patch does > seems fine. Indeed, thanks Arne for reporting this. > Also, a bit downstream I see > > (if (not pubdate0) "" ;; Skip entries with no PUBDATE prop > > It seems like this should be updated to look at pubdate rather than > pubdate0 to avoid "<pubDate>nil</pubDate>" for the empty string > case. Indeed too. Applied as commit 8ab1e30db in maint. Thanks, -- Bastien
prev parent reply other threads:[~2021-04-30 7:06 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-07 1:56 Dr. Arne Babenhauserheide 2021-01-10 23:08 ` Kyle Meyer 2021-04-30 7:04 ` Bastien [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).