From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id JiyLLX2si2BpvwAAgWs5BA (envelope-from ) for ; Fri, 30 Apr 2021 09:06:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uPZLKH2si2BBCgAA1q6Kng (envelope-from ) for ; Fri, 30 Apr 2021 07:06:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39AC91CC7C for ; Fri, 30 Apr 2021 09:06:37 +0200 (CEST) Received: from localhost ([::1]:45218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcNER-0001nb-LY for larch@yhetil.org; Fri, 30 Apr 2021 03:06:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcNDH-0001ll-45 for emacs-orgmode@gnu.org; Fri, 30 Apr 2021 03:05:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58190) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcNDE-0004MA-4S; Fri, 30 Apr 2021 03:05:21 -0400 Received: from [2a01:e34:ec2b:7150:140b:2dc1:d41f:4033] (port=46326 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lcNCs-0005t8-SK; Fri, 30 Apr 2021 03:04:59 -0400 Received: by guerry (Postfix, from userid 1000) id EB50D1A60EE2; Fri, 30 Apr 2021 09:04:55 +0200 (CEST) From: Bastien To: Kyle Meyer Subject: Re: Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)] In-Reply-To: <87k0skpezy.fsf@kyleam.com> (Kyle Meyer's message of "Sun, 10 Jan 2021 23:08:02 GMT") Organization: GNU References: <875z49echi.fsf@web.de> <87k0skpezy.fsf@kyleam.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) X-Woof-Patch: applied Date: Fri, 30 Apr 2021 09:04:55 +0200 Message-ID: <87sg38ckx4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. Arne Babenhauserheide" , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619766397; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=V4UGliCkARnfSCMcsDmmpvAX62Gpuz0Vq1OLHufhKTM=; b=m4iyvRvjC5wpnx7WUyyYU+q3sNS4OJZKkDpUeMQfag6QPyf5MsisU7Qs4mTG3J+47BZFIh xK+MBaXkqQC3QY6Wtx3R5oPQEgK9wPPMRsncb/LOw7GSFAKU9BHfFUNFQCm7Wqmcg+vDKO 1nlD9R1KJGJuv1dej5VDOLi95z3R73Wac36d1IjzpXf3SRtg1+1zUn6F+RFyXGUYAA5Htf 6YrzhmOOoH/PydgtA7RBqAnz+H4czoHZZSmxVJJO+cJ1KUDVR0eEuGdPsfTs2msYMcGapk EA2KeSEHXeu9D3taVgKf9y+AXLVpG7EbajHzRPjsG/5nKzFCPpCigthXeH4mDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619766397; a=rsa-sha256; cv=none; b=bfIsOdw80beazlep5IYhwY9PAYWy0yUZAPgNHcu4Zfxn3pSZaioxhvodfekB3qDWqfCbnp zCvh4pHANpZQO6xyWnNc2PJD3Gd1GLCZhsnS2f39WA9iebQ29YIyTPBCWTAheqKjfW07fs +LQKa4XuH5Hcvf7sidYl+DIR3V+LxxEM3GFVysRighCE0tg7zH8YxNDXft+6kvn03ZL430 VQRKe+SL+GBDMZOy7Ck7nQbIoboXRlPPEecIA9Z/zGit01QVbrM8jP3QlmkPVtRqyBEOTM g28jVaT/W4XK54+bziWqqCncGjo3ODY2kpHTDo73Q7S5afSQL83QqFESkVlPrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.46 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 39AC91CC7C X-Spam-Score: -1.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: aivvwbEE9SHk Hi Kyle and Arne, Kyle Meyer writes: > I'm not an ox-rss user and don't know if there are more realistic ways > to hit this error, but I was able to trigger it by taking an already > exported buffer of > > * h1 > :PROPERTIES: > :ID: 76841adc-b233-4f6d-8446-3478f263544b > :PUBDATE: <2021-01-10 Sun 17:46> > :END: > > and then setting PUBDATE to an empty string and exporting again. > > I'm not sure if the error you see is indicative of a larger issue, > though either way guarding against an empty string as your patch does > seems fine. Indeed, thanks Arne for reporting this. > Also, a bit downstream I see > > (if (not pubdate0) "" ;; Skip entries with no PUBDATE prop > > It seems like this should be updated to look at pubdate rather than > pubdate0 to avoid "nil" for the empty string > case. Indeed too. Applied as commit 8ab1e30db in maint. Thanks, -- Bastien