emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: "Y. E." <yet@ego.team>, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: [PATCH] Re: [BUG] Set org-format-latex-options in .dir-locals.el [9.5.1 (release_9.5.1-11-g96d91b @ emacs-28.0.90/lisp/org/)]
Date: Fri, 06 May 2022 18:21:29 +0800	[thread overview]
Message-ID: <87sfpn6jx2.fsf@localhost> (raw)
In-Reply-To: <m2fsqr75md.fsf@ego.team>

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

Y. E. via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
writes:

> Hello,
>
> I tried configuring 'org-format-latex-options' per a org-mode
> file/directory by adding the following configuration into the
> .dir-locals.el file:
> The file settings I use:
>
> #+STARTUP: content latexpreview
> #+OPTIONS: tex:dvisvgm html-style:nil
> #+HTML_HEAD: <link rel="stylesheet" type="text/css" href="style.css" />
>
> The LaTeX formulas are embedded into the text as shown here:
> https://orgmode.org/manual/LaTeX-fragments.html
>
> Am I overlooking something?

Nope. This is a bug.

It happens because LaTeX fragments are processed in temporary buffer and
all the buffer-local variables you set in the original org buffer are
discarded.

The fix is attached.

Nicolas, this kind of error might be present in various places of export
library. You may want to fix it in more places than what I propose in
this patch.

Best,
Ihor


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-html-format-latex-Preserve-buffer-local-settings.patch --]
[-- Type: text/x-patch, Size: 1565 bytes --]

From 37a37862a17c4b333164edffbac97f8a56052e88 Mon Sep 17 00:00:00 2001
Message-Id: <37a37862a17c4b333164edffbac97f8a56052e88.1651832231.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Fri, 6 May 2022 18:14:05 +0800
Subject: [PATCH] org-html-format-latex: Preserve buffer-local settings

* lisp/ox-html.el (org-html-format-latex): Carry over buffer-local
variables when create LaTeX images.  Use `org-export-with-buffer-copy'
instead of `with-temp-buffer'.

Fixes https://orgmode.org/list/m2fsqr75md.fsf@ego.team
---
 lisp/ox-html.el | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 81ef002a0..7f2087a46 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -2872,11 +2872,12 @@ (defun org-html-format-latex (latex-frag processing-type info)
 	;; temporary buffer so that dvipng/imagemagick can properly
 	;; turn the fragment into an image.
 	(setq latex-frag (concat latex-header latex-frag))))
-    (with-temp-buffer
-      (insert latex-frag)
-      (org-format-latex cache-relpath nil nil cache-dir nil
-			"Creating LaTeX Image..." nil processing-type)
-      (buffer-string))))
+    (org-export-with-buffer-copy
+     (erase-buffer)
+     (insert latex-frag)
+     (org-format-latex cache-relpath nil nil cache-dir nil
+		       "Creating LaTeX Image..." nil processing-type)
+     (buffer-string))))
 
 (defun org-html--wrap-latex-environment (contents _ &optional caption label)
   "Wrap CONTENTS string within appropriate environment for equations.
-- 
2.35.1


  reply	other threads:[~2022-05-06 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 12:55 [BUG] Set org-format-latex-options in .dir-locals.el [9.5.1 (release_9.5.1-11-g96d91b @ emacs-28.0.90/lisp/org/)] Y. E. via General discussions about Org-mode.
2022-05-06 10:21 ` Ihor Radchenko [this message]
2022-07-20  7:14   ` [PATCH] " Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfpn6jx2.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=yet@ego.team \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).