emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Eric Schulte" <schulte.eric@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: ido's flex matching in org-refile
Date: Sun, 16 Nov 2008 18:33:36 -0800	[thread overview]
Message-ID: <87r65brshr.fsf@gmail.com> (raw)
In-Reply-To: <87bpwfpboc.fsf@gollum.intra.norang.ca> (Bernt Hansen's message of "Sun, 16 Nov 2008 17:07:31 -0500")

Bernt Hansen <bernt@norang.ca> writes:

> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> Hi Eric, this is very nice, but the changes also contain a whole
>> mountain of changes where only the initial whitespace of lines is
>> changed.  This makes it very har to see what really is the core of
>> this patch and makes me hesitate to apply it.
>>
>> Can this be avoided somehow?   Bernt?
>

Hi,

My bad, I only meant to re-indent the lines affected by the change in
name length from completing-read to org-ido-completing-read, but
apparently my brush was a little broad.

Carsten,
please do just apply the non-whitespace changes as Bernt described
below.  If this proves difficult let me know, and I will redo the
changes against the current git-head and shoot you a link.

Thanks -- Eric

>
> Carsten,
>
> From your repository you can do this:
>
> $ git fetch git://github.com/eschulte/org-mode master
>
> This pulls the commits from Eric's master branch and points your
> FETCH_HEAD at it.
>
> $ git diff master FETCH_HEAD
>
> shows the differences between your master and all commits to FETCH_HEAD
> (basically the same thing when you just show that commit).  In this case
> it's the same as git show FETCH_HEAD since there is only one commit.
>
> $ git diff -w master FETCH_HEAD
>
> will ignore whitespace changes.  This is much easier to review.
>
> -Bernt

next prev parent reply	other threads:[~2008-11-17  2:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10  2:11 ido's flex matching in org-refile Samuel Wales
2008-11-10  8:14 ` Carsten Dominik
2008-11-15  6:10   ` Samuel Wales
2008-11-16 20:07   ` Eric Schulte
2008-11-16 20:26     ` Carsten Dominik
2008-11-16 22:07       ` Bernt Hansen
2008-11-17  2:33         ` Eric Schulte [this message]
2008-11-17  6:56     ` Carsten Dominik
2008-11-21 11:23       ` Rick Moynihan
2008-11-21 11:34         ` Carsten Dominik
2008-11-21 14:06           ` Rick Moynihan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r65brshr.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).