From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eric Schulte" <schulte.eric@gmail.com>
Subject: Re: ido's flex matching in org-refile
Date: Sun, 16 Nov 2008 18:33:36 -0800
Message-ID: <87r65brshr.fsf@gmail.com>
References: <20524da70811091811r51fcbfdaue35fa583e35ec361@mail.gmail.com>
	<77A67AB4-322B-428A-BB70-CD615E32FC65@uva.nl>
	<87myfzph7v.fsf@gmail.com>
	<D99152EE-CEE6-464E-9CBF-843C9956DEE5@uva.nl>
	<87bpwfpboc.fsf@gollum.intra.norang.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L1tvj-0008Uf-PP
	for emacs-orgmode@gnu.org; Sun, 16 Nov 2008 21:33:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L1tvh-0008UT-TP
	for emacs-orgmode@gnu.org; Sun, 16 Nov 2008 21:33:35 -0500
Received: from [199.232.76.173] (port=53937 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L1tvh-0008UM-Mp
	for emacs-orgmode@gnu.org; Sun, 16 Nov 2008 21:33:33 -0500
Received: from wa-out-1112.google.com ([209.85.146.179]:30141)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <schulte.eric@gmail.com>) id 1L1tvh-0006Gp-Gu
	for emacs-orgmode@gnu.org; Sun, 16 Nov 2008 21:33:33 -0500
Received: by wa-out-1112.google.com with SMTP id n4so2102184wag.26
	for <emacs-orgmode@gnu.org>; Sun, 16 Nov 2008 18:33:31 -0800 (PST)
In-Reply-To: <87bpwfpboc.fsf@gollum.intra.norang.ca> (Bernt Hansen's message
	of "Sun, 16 Nov 2008 17:07:31 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org

Bernt Hansen <bernt@norang.ca> writes:

> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> Hi Eric, this is very nice, but the changes also contain a whole
>> mountain of changes where only the initial whitespace of lines is
>> changed.  This makes it very har to see what really is the core of
>> this patch and makes me hesitate to apply it.
>>
>> Can this be avoided somehow?   Bernt?
>

Hi,

My bad, I only meant to re-indent the lines affected by the change in
name length from completing-read to org-ido-completing-read, but
apparently my brush was a little broad.

Carsten,
please do just apply the non-whitespace changes as Bernt described
below.  If this proves difficult let me know, and I will redo the
changes against the current git-head and shoot you a link.

Thanks -- Eric

>
> Carsten,
>
> From your repository you can do this:
>
> $ git fetch git://github.com/eschulte/org-mode master
>
> This pulls the commits from Eric's master branch and points your
> FETCH_HEAD at it.
>
> $ git diff master FETCH_HEAD
>
> shows the differences between your master and all commits to FETCH_HEAD
> (basically the same thing when you just show that commit).  In this case
> it's the same as git show FETCH_HEAD since there is only one commit.
>
> $ git diff -w master FETCH_HEAD
>
> will ignore whitespace changes.  This is much easier to review.
>
> -Bernt