From: Niels Giesen <niels.giesen@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org, Christian Egli <christian.egli@sbs.ch>
Subject: Re: Patch for bug in adjusting time ranges in Agenda
Date: Sat, 22 Oct 2011 11:49:30 +0200 [thread overview]
Message-ID: <87r525bbkl.fsf@gmail.com> (raw)
In-Reply-To: <92122B10-83C7-4A3C-9379-4D22E465FCA0@gmail.com> (Carsten Dominik's message of "Sat, 22 Oct 2011 08:40:46 +0200")
Carsten Dominik <carsten.dominik@gmail.com> writes:
> On 21.10.2011, at 10:54, Christian Egli wrote:
>
>> Hi Carsten
>>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>>> I have just checked in a slightly modified patch.
>>
>> I think there is a problem with this checkin. The variable
>> org-agenda-move-date-from-past-immediately-to-today is not defined.
>> Should this be a defcustom somewhere?
>
> Yes, I forgot to put that in. Done now.
>
Hmm. Found another bug, which presumably existed with my original patch
too:
#+begin_example
Week-agenda (W42):
Monday 17 October 2011 W42
org: Scheduled: finish plugin
org: (1/3): finish plugin
Tuesday 18 October 2011
org: (2/3): finish plugin
Wednesday 19 October 2011
org: (3/3): finish plugin
Thursday 20 October 2011
Friday 21 October 2011
Saturday 22 October 2011
org: Sched. 6x: finish plugin
Sunday 23 October 2011
#+end_example
When on the line
: org: Scheduled: finish plugin
or on the line
: org: Sched. 6x: finish plugin
`org-agenda-later' doesn't work properly. This is because org-marker is
at the beginning of the timestamp at these kind of entries, not the end.
This causes both `org-at-date-range-p' to return nil and (presuming it
did return t) the re-search-backward code to fail.
On the other entries (the 1/3, 2/3 and 3/3 lines) shifting the date does
work, as the marker is at the end of the date range.
I am not sure as to the proper course of action here:
1. should the initial marker point to the end of the date range?
2. should `org-at-date-range-p' return t too at the beginning of a date range?
3. should `org-date-later' handle the case where the marker is at the
beginning of a date range itself?
--
http://pft.github.com/
prev parent reply other threads:[~2011-10-22 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 10:24 Patch for bug in adjusting time ranges in Agenda Niels Giesen
2011-10-16 16:27 ` Niels Giesen
2011-10-16 16:43 ` Nick Dokos
2011-10-17 8:50 ` Niels Giesen
2011-10-17 14:50 ` Nick Dokos
2011-10-20 7:38 ` Carsten Dominik
2011-10-21 8:07 ` Carsten Dominik
2011-10-21 8:54 ` Christian Egli
2011-10-22 6:00 ` Niels Giesen
2011-10-22 6:24 ` Carsten Dominik
2011-10-22 6:40 ` Carsten Dominik
2011-10-22 9:49 ` Niels Giesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r525bbkl.fsf@gmail.com \
--to=niels.giesen@gmail.com \
--cc=carsten.dominik@gmail.com \
--cc=christian.egli@sbs.ch \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).