From mboxrd@z Thu Jan 1 00:00:00 1970 From: Niels Giesen Subject: Re: Patch for bug in adjusting time ranges in Agenda Date: Sat, 22 Oct 2011 11:49:30 +0200 Message-ID: <87r525bbkl.fsf@gmail.com> References: <87obxzitcv.fsf@gmail.com> <31715.1318783422@alphaville.dokosmarshall.org> <40F93CA9-B11C-45D7-814A-1AF6225BF342@gmail.com> <87r526vi5f.fsf@sbs.ch> <92122B10-83C7-4A3C-9379-4D22E465FCA0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:49363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHYCt-0006aD-8S for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 05:49:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHYCr-0001YI-UA for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 05:49:35 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:63161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHYCr-0001X9-Lj for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 05:49:33 -0400 Received: by eye4 with SMTP id 4so5164122eye.0 for ; Sat, 22 Oct 2011 02:49:32 -0700 (PDT) In-Reply-To: <92122B10-83C7-4A3C-9379-4D22E465FCA0@gmail.com> (Carsten Dominik's message of "Sat, 22 Oct 2011 08:40:46 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org, Christian Egli Carsten Dominik writes: > On 21.10.2011, at 10:54, Christian Egli wrote: > >> Hi Carsten >> >> Carsten Dominik writes: >> >>> I have just checked in a slightly modified patch. >> >> I think there is a problem with this checkin. The variable >> org-agenda-move-date-from-past-immediately-to-today is not defined. >> Should this be a defcustom somewhere? > > Yes, I forgot to put that in. Done now. > Hmm. Found another bug, which presumably existed with my original patch too: #+begin_example Week-agenda (W42): Monday 17 October 2011 W42 org: Scheduled: finish plugin org: (1/3): finish plugin Tuesday 18 October 2011 org: (2/3): finish plugin Wednesday 19 October 2011 org: (3/3): finish plugin Thursday 20 October 2011 Friday 21 October 2011 Saturday 22 October 2011 org: Sched. 6x: finish plugin Sunday 23 October 2011 #+end_example When on the line : org: Scheduled: finish plugin or on the line : org: Sched. 6x: finish plugin `org-agenda-later' doesn't work properly. This is because org-marker is at the beginning of the timestamp at these kind of entries, not the end. This causes both `org-at-date-range-p' to return nil and (presuming it did return t) the re-search-backward code to fail. On the other entries (the 1/3, 2/3 and 3/3 lines) shifting the date does work, as the marker is at the end of the date range. I am not sure as to the proper course of action here: 1. should the initial marker point to the end of the date range? 2. should `org-at-date-range-p' return t too at the beginning of a date range? 3. should `org-date-later' handle the case where the marker is at the beginning of a date range itself? -- http://pft.github.com/