emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Daimrod <daimrod@gmail.com>
To: Martin <vbmazter@web.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Smart inference of task progress when exporting to TJ3
Date: Fri, 03 May 2013 10:40:25 +0200	[thread overview]
Message-ID: <87r4hobgna.fsf@tanger.home> (raw)
In-Reply-To: 0LlWCR-1TzVer28MZ-00b7Lb@smtp.web.de

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Martin <vbmazter@web.de> writes:

Hello Martin,

Thanks for your patch. I will only make a few stylistic remarks.

1. Could you add `contrib/lisp/ox-taskjuggler.el:' to the subject? (The
   first line of the commit message)
   
2. IIUC you don't need the TINYCHANGE cookie because the changes are
   made in contrib/ which doesn't require copyright assignment.
   Furthermore, I don't think your changes could be considered `tiny'
   (it changes more than 20 lines and doesn't look like a rewrite).

3. Could you reformat a bit your code so it fit in 80 column? (You can
   often use M-q for the comments)

-- 
Daimrod/Greg

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

next prev parent reply	other threads:[~2013-05-03  8:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 21:24 [PATCH] Smart inference of task progress when exporting to TJ3 Martin
2013-05-03  8:40 ` Daimrod [this message]
2013-05-03 11:26   ` Martin Becker
2013-05-03 15:08     ` Christian Egli
2013-05-03 17:05       ` Martin Becker
2013-05-03 20:25         ` Christian Egli
2013-05-03 23:06           ` Martin Becker
2013-05-07 10:08       ` Bastien
2013-05-07 10:57         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4hobgna.fsf@tanger.home \
    --to=daimrod@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=vbmazter@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).