From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daimrod Subject: Re: [PATCH] Smart inference of task progress when exporting to TJ3 Date: Fri, 03 May 2013 10:40:25 +0200 Message-ID: <87r4hobgna.fsf@tanger.home> References: <0LlWCR-1TzVer28MZ-00b7Lb@smtp.web.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYBV6-00010S-RY for emacs-orgmode@gnu.org; Fri, 03 May 2013 04:37:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYBV5-0006ZS-Uf for emacs-orgmode@gnu.org; Fri, 03 May 2013 04:37:56 -0400 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:42106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYBV5-0006ZE-P8 for emacs-orgmode@gnu.org; Fri, 03 May 2013 04:37:55 -0400 Received: by mail-we0-f170.google.com with SMTP id z53so1161614wey.1 for ; Fri, 03 May 2013 01:37:54 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martin Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Martin writes: Hello Martin, Thanks for your patch. I will only make a few stylistic remarks. 1. Could you add `contrib/lisp/ox-taskjuggler.el:' to the subject? (The first line of the commit message) =20=20=20 2. IIUC you don't need the TINYCHANGE cookie because the changes are made in contrib/ which doesn't require copyright assignment. Furthermore, I don't think your changes could be considered `tiny' (it changes more than 20 lines and doesn't look like a rewrite). 3. Could you reformat a bit your code so it fit in 80 column? (You can often use M-q for the comments) =2D-=20 Daimrod/Greg --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRg3f/AAoJEBNzVHcrZRiUrAEQAJFwLvvHYXioQUDXxrsPRk2o N7WbxJmy/faXdA17B7+EBxorBaLd2h+5JXYSQGDbNeTeokv1cW/GPETP6jp436qT pA7R53m7atHKwjkdMrSNHgduK/Gj86nZY7Vt+MoTkcVn07Y8xEdZbzQaIGcWW2Xg gMM6okLhK544DiFmytjykxYNQ430r7vrA7z1UVGoEEKe1PwJau11l65JPaHO3jEO lLITV61r+4mA7MXL46+NE8XYO8xCYVYKLrUW5dvJn6n7r3jNEzFxMFkwaV2XYVaY t+me7duy5XW7EtrTU7Cg3qRxyrLzHdujv6hov78nzIAJeeIQYDCR6H6SZR9s5Omn KXB3nOOhMOBTEDy1I5/sDQyMv/ijDNr/SMyfg9Fu1Le4Q3OJHe9lJ8Wjpl2t4Yf8 U29xtKgcaZ0S3qPgabdKlqv/qWfcV2sfkC+yZnplloChImHCfykTc3gnLnbEY0rK RkE4U6ORuUedPvTjwY8CZkINPYIPhhBFYIMGZvs5ltEFZcKSCaO0nsiTVmwIvBLB H1kNyX4vBNgR2CvXmADY7cb2sBzp+W0/L2Mr9fslvb2IoVwx19/gk7kKs+4wQZvZ rrm2Ik/KsMqazE514Nv0uN9QsttmYVFYLHaro7MfbGsvpexAgvmnRQCMLqbbJ5aY zs86jTC7YTDSVtUXKJnv =Kkug -----END PGP SIGNATURE----- --=-=-=--