emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Feng Shu <tumashu@gmail.com>
Cc: orgmode <emacs-orgmode@gnu.org>
Subject: Re: [patch] [2update] Add functions, which can quickly insert org-contacts template(s) in current buffer
Date: Tue, 04 Jun 2013 11:55:34 +0200	[thread overview]
Message-ID: <87r4gifbe1.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87vc5vm96n.fsf@news.tumashu-localhost.org> (Feng Shu's message of "Tue, 04 Jun 2013 00:49:04 +0800")

Hi Feng,

Feng Shu <tumashu@gmail.com> writes:

> * contrib/lisp/org-contacts.el (org-contacts-build-template-with-exist-contact):Build
> a contact template with exist contact, It is useful when you want to update exist contact(s).
> (org-contacts-build-template-with-string): Build contact template with
> a string, It is useful when you want to add a new contact.
> (org-contacts-insert-template): Insert contact template(s) at point,
> the template(s) will be built with the input string and exist contacts
> informations.

Here is a reformatted ChangeLog for your patch:

* contrib/lisp/org-contacts.el
(org-contacts-build-template-with-exist-contact)
(org-contacts-build-template-with-string): New methods for
building a contact template.
(org-contacts-insert-template): Insert a contact template at
point.  The template will be built with the input string and
existing contact informations.

The point is: try to be a bit more terse in your explanations,
and to pay attention to the punctuation.

Sorry to nitpick about this -- even if the change is for contrib/,
it's good to know about the rules early on, and to lower the work
of maintainers because all the change logs need to be reviewed
at some point.

Thanks for your efforts and your work on org-contacts.el!

-- 
 Bastien

next prev parent reply	other threads:[~2013-06-04 10:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 16:49 [patch] [2update] Add functions, which can quickly insert org-contacts template(s) in current buffer Feng Shu
2013-06-03 23:07 ` Feng Shu
2013-06-04  3:29   ` [patch] [3update] Add functions, Insert a exist contact name at point Feng Shu
2013-06-04  9:41     ` Feng Shu
2013-06-04  9:55 ` Bastien [this message]
2013-06-04 11:17   ` [patch] [2update] Add functions, which can quickly insert org-contacts template(s) in current buffer Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4gifbe1.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=tumashu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).