From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [patch] [2update] Add functions, which can quickly insert
 org-contacts template(s) in current buffer
Date: Tue, 04 Jun 2013 11:55:34 +0200
Message-ID: <87r4gifbe1.fsf@bzg.ath.cx>
References: <87vc5vm96n.fsf@news.tumashu-localhost.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1Ujo2k-0002QW-43
	for emacs-orgmode@gnu.org; Tue, 04 Jun 2013 06:00:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1Ujo2e-00088C-Oi
	for emacs-orgmode@gnu.org; Tue, 04 Jun 2013 06:00:42 -0400
Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:33197)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1Ujo2e-00087L-GH
	for emacs-orgmode@gnu.org; Tue, 04 Jun 2013 06:00:36 -0400
Received: by mail-ea0-f176.google.com with SMTP id o14so3218eaj.21
	for <emacs-orgmode@gnu.org>; Tue, 04 Jun 2013 03:00:35 -0700 (PDT)
In-Reply-To: <87vc5vm96n.fsf@news.tumashu-localhost.org> (Feng Shu's message
	of "Tue, 04 Jun 2013 00:49:04 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Feng Shu <tumashu@gmail.com>
Cc: orgmode <emacs-orgmode@gnu.org>

Hi Feng,

Feng Shu <tumashu@gmail.com> writes:

> * contrib/lisp/org-contacts.el (org-contacts-build-template-with-exist-contact):Build
> a contact template with exist contact, It is useful when you want to update exist contact(s).
> (org-contacts-build-template-with-string): Build contact template with
> a string, It is useful when you want to add a new contact.
> (org-contacts-insert-template): Insert contact template(s) at point,
> the template(s) will be built with the input string and exist contacts
> informations.

Here is a reformatted ChangeLog for your patch:

* contrib/lisp/org-contacts.el
(org-contacts-build-template-with-exist-contact)
(org-contacts-build-template-with-string): New methods for
building a contact template.
(org-contacts-insert-template): Insert a contact template at
point.  The template will be built with the input string and
existing contact informations.

The point is: try to be a bit more terse in your explanations,
and to pay attention to the punctuation.

Sorry to nitpick about this -- even if the change is for contrib/,
it's good to know about the rules early on, and to lower the work
of maintainers because all the change logs need to be reviewed
at some point.

Thanks for your efforts and your work on org-contacts.el!

-- 
 Bastien