emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Sebastien Vauban
	<public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org>
Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org
Subject: Re: [bug] YASnippet (bound to SPC) and Org in `master'
Date: Tue, 25 Nov 2014 09:37:08 +0100	[thread overview]
Message-ID: <87r3wroevf.fsf@selenimh.mobile.lan> (raw)
In-Reply-To: <8661e57xom.fsf@example.com> (Sebastien Vauban's message of "Mon, 24 Nov 2014 10:30:33 +0100")



Hello,

Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> In Org `master' (not in `maint'), there is a bug (or conflict or ???)
> when one binds `yas-expand' to SPC (the "abbrev-way"), as in the
> following minimal Emacs configuration file:

[...]

> With the above config, typing SPC after any word in any Org table cell
> deletes the whole contents of the cell... [1]
>
> When typing, for example, "Every word gets deleted on pressing SPC...",
> you successively only see "Every", then "word", then "gets", ..., and
> then finally "SPC..." as the cell contents!
>
> Searching for the difference between `maint' and `master' shows that the
> problem occurs since the following commit in `master':
>
> e8b51c0ce5d6dbd5f2c6cfff2d260a3f5f7ac58f is the first bad commit
> commit e8b51c0ce5d6dbd5f2c6cfff2d260a3f5f7ac58f
> Author: Bastien Guerry <bzg-whniv8GeeGkdnm+yROfE0A@public.gmane.org>
> Date:   Mon Jul 28 17:28:54 2014 +0200
>
>     org.el (org-self-insert-command): Use `yas-expand'
>
>     * org.el (org-self-insert-command): Use `yas-expand' as
>     yas/expand is obsolete since Yasnippet 0.8.

I don't understand why yas-expand (or yas/expand) appears in
`org-self-insert-command'. This feature was introduced for the first
time in 94c4f801a2a8f0e0e14b48719c22e06dd9a1e599:

    Tables: Fix auto-blanking of fields is yasnippet is active.
    
    When yasnippet is active, it is the official binding of TAB.  That
    means, the org-mode self-insert command must know that it may blank
    table fields if the last command was yas/expand.

The "must know" part is not clear to me. I tend to think we should
remove it.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2014-11-25  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24  9:30 [bug] YASnippet (bound to SPC) and Org in `master' Sebastien Vauban
2014-11-25  8:37 ` Nicolas Goaziou [this message]
2014-11-25 14:16   ` Sebastien Vauban
2014-11-25 15:09     ` Nicolas Goaziou
2014-12-03 20:40       ` Nicolas Goaziou
2014-12-03 21:19         ` Sebastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3wroevf.fsf@selenimh.mobile.lan \
    --to=mail@nicolasgoaziou.fr \
    --cc=public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org \
    --cc=public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).