From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [bug] YASnippet (bound to SPC) and Org in `master' Date: Tue, 25 Nov 2014 09:37:08 +0100 Message-ID: <87r3wroevf.fsf@selenimh.mobile.lan> References: <8661e57xom.fsf@example.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtBcA-0005pc-Ke for emacs-orgmode@gnu.org; Tue, 25 Nov 2014 03:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtBc2-0004JB-Sf for emacs-orgmode@gnu.org; Tue, 25 Nov 2014 03:36:50 -0500 Received: from plane.gmane.org ([80.91.229.3]:41456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtBc2-0004IY-Lc for emacs-orgmode@gnu.org; Tue, 25 Nov 2014 03:36:42 -0500 Received: from public by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XtBbx-0002JA-D8 for emacs-orgmode@gnu.org; Tue, 25 Nov 2014 09:36:37 +0100 In-Reply-To: <8661e57xom.fsf@example.com> (Sebastien Vauban's message of "Mon, 24 Nov 2014 10:30:33 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sebastien Vauban Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org Hello, Sebastien Vauban writes: > In Org `master' (not in `maint'), there is a bug (or conflict or ???) > when one binds `yas-expand' to SPC (the "abbrev-way"), as in the > following minimal Emacs configuration file: [...] > With the above config, typing SPC after any word in any Org table cell > deletes the whole contents of the cell... [1] > > When typing, for example, "Every word gets deleted on pressing SPC...", > you successively only see "Every", then "word", then "gets", ..., and > then finally "SPC..." as the cell contents! > > Searching for the difference between `maint' and `master' shows that the > problem occurs since the following commit in `master': > > e8b51c0ce5d6dbd5f2c6cfff2d260a3f5f7ac58f is the first bad commit > commit e8b51c0ce5d6dbd5f2c6cfff2d260a3f5f7ac58f > Author: Bastien Guerry > Date: Mon Jul 28 17:28:54 2014 +0200 > > org.el (org-self-insert-command): Use `yas-expand' > > * org.el (org-self-insert-command): Use `yas-expand' as > yas/expand is obsolete since Yasnippet 0.8. I don't understand why yas-expand (or yas/expand) appears in `org-self-insert-command'. This feature was introduced for the first time in 94c4f801a2a8f0e0e14b48719c22e06dd9a1e599: Tables: Fix auto-blanking of fields is yasnippet is active. When yasnippet is active, it is the official binding of TAB. That means, the org-mode self-insert command must know that it may blank table fields if the last command was yas/expand. The "must know" part is not clear to me. I tend to think we should remove it. Regards, -- Nicolas Goaziou