emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Cc: monnier@iro.umontreal.ca
Subject: Re: Avoiding `intangible'
Date: Thu, 16 Apr 2015 11:50:31 +0200	[thread overview]
Message-ID: <87r3rk9zbs.fsf@gmx.us> (raw)
In-Reply-To: jwva8y8j1ok.fsf-monnier+emacs@gnu.org

Hi Stefan,

Thanks for the patch.

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> I'm on a crusade to eradicate the `intangible' property, which happens
> to rub me the wrong way because it's implemented at too-low a level (it
> affects every point movement) which incurs a significant performance
> penalty (even when not used) and affects a lot of code which then
> needs to be fixed by binding inhibit-point-motion-hooks (which I'm
> considering defaulting to t).

OK.  In addition to the places you've identified, it's also mentioned
here:

./contrib/lisp/org-colview-xemacs.el:396:     (overlay-put ov 'intangible t)
./contrib/lisp/org-eval.el:154:	 (list 'display value 'intangible t 'font-lock-multiline t
./lisp/org.el:11165:	(unless (get-text-property (match-end group) 'intangible) ; Emacs 21


> So I'd like to install the patch below.  Any objection?  The `invisible'
> property already ensures that the command loop moves point away from
> those overlays, so the `intangible' property should not be needed there
> (tho I don't use Org enough to know how to test it).

I can't even make the first modified function do what it is documented to
do.  From the special text properties documentation and the documentation
of the changed I don't see a reason why it would not be OK.

I'll install it in master and it will eventually get back to Emacs-core
once 8.3 released assuming no unforeseen breakages are associated with the
change.

Thanks,
Rasmus

-- 
Not everything that goes around comes back around, you know

     prev parent reply	other threads:[~2015-04-16  9:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwv8ue0i12i.fsf-monnier+emacs@gnu.org>
2015-04-16  1:42 ` Avoiding `intangible' Stefan Monnier
2015-04-16  9:50   ` Rasmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3rk9zbs.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).