emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-orgmode@gnu.org
Subject: Avoiding `intangible'
Date: Wed, 15 Apr 2015 21:42:54 -0400	[thread overview]
Message-ID: <jwva8y8j1ok.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv8ue0i12i.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 10 Apr 2015 09:12:53 -0400")

I'm on a crusade to eradicate the `intangible' property, which happens
to rub me the wrong way because it's implemented at too-low a level (it
affects every point movement) which incurs a significant performance
penalty (even when not used) and affects a lot of code which then
needs to be fixed by binding inhibit-point-motion-hooks (which I'm
considering defaulting to t).

So I'd like to install the patch below.  Any objection?  The `invisible'
property already ensures that the command loop moves point away from
those overlays, so the `intangible' property should not be needed there
(tho I don't use Org enough to know how to test it).


        Stefan


diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el
index 8f7611f..bac8206 100644
--- a/lisp/org/org-agenda.el
+++ b/lisp/org/org-agenda.el
@@ -3847,8 +3847,7 @@ dimming them."
 		  e (point-at-eol)
 		  ov (make-overlay b e))
 	    (if invis1
-		(progn (overlay-put ov 'invisible t)
-		       (overlay-put ov 'intangible t))
+                (overlay-put ov 'invisible t)
 	      (overlay-put ov 'face 'org-agenda-dimmed-todo-face))
 	    (overlay-put ov 'org-type 'org-blocked-todo))))))
   (when (org-called-interactively-p 'interactive)
diff --git a/lisp/org/org-colview.el b/lisp/org/org-colview.el
index e14849f..2587aad 100644
--- a/lisp/org/org-colview.el
+++ b/lisp/org/org-colview.el
@@ -250,7 +250,6 @@ This is the compiled version of the format.")
      (setq ov (org-columns-new-overlay beg (point-at-eol)))
      (overlay-put ov 'invisible t)
      (overlay-put ov 'keymap org-columns-map)
-     (overlay-put ov 'intangible t)
      (overlay-put ov 'line-prefix "")
      (overlay-put ov 'wrap-prefix "")
      (push ov org-columns-overlays)

       reply	other threads:[~2015-04-16  1:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwv8ue0i12i.fsf-monnier+emacs@gnu.org>
2015-04-16  1:42 ` Stefan Monnier [this message]
2015-04-16  9:50   ` Avoiding `intangible' Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwva8y8j1ok.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).