emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nick Dokos <ndokos@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: PATCH: add dbport to ob-sql for postgres
Date: Wed, 14 Sep 2016 21:26:45 -0400	[thread overview]
Message-ID: <87r38mx8a2.fsf@gmail.com> (raw)
In-Reply-To: 87mvjayvk0.fsf@openaether.org

Justin Kirby <justinkirby@gmail.com> writes:

> In ob-sql postgres would ignore dbport header argument. Attached is a
> patch that corrects this.
>
> Let me know if there are any modifications needed.
>

Three things:

o This probably qualifies as a TINYCHANGE and can be merged, but if
  you want to contribute in the future, you will probably have to sign
  the FSF copyright assignment (unless you have done so
  already). Details can be found at

   http://orgmode.org/worg/org-contribute.html#orgheadline1

o The best way to submit patches is by using ``git format-patch''.
  There are also conventions that you need to follow - details can be
  found at

   http://orgmode.org/worg/org-contribute.html#patches

  Since org-mode is a part of emacs, you will need to add a commit
  message that is formatted as an Emacs ChangeLog entry. The URL above
  has all the details.

o On the positive side, the news entry and the test(s) you provided are
  very much appreciated.

Nicolas Goaziou (or another maintainer) may want to add to this, but I
think it covers the basics.

Thanks!
-- 
Nick

next prev parent reply	other threads:[~2016-09-15  3:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 22:18 PATCH: add dbport to ob-sql for postgres Justin Kirby
2016-09-15  1:26 ` Nick Dokos [this message]
2016-09-15 13:30   ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r38mx8a2.fsf@gmail.com \
    --to=ndokos@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).