From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Dokos <ndokos@gmail.com>
Subject: Re: PATCH: add dbport to ob-sql for postgres
Date: Wed, 14 Sep 2016 21:26:45 -0400
Message-ID: <87r38mx8a2.fsf@gmail.com>
References: <87mvjayvk0.fsf@openaether.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bkN6C-0007JQ-Iu
	for emacs-orgmode@gnu.org; Wed, 14 Sep 2016 23:12:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bkN68-00025Y-K1
	for emacs-orgmode@gnu.org; Wed, 14 Sep 2016 23:12:27 -0400
Received: from [195.159.176.226] (port=54371 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bkN68-000250-CP
	for emacs-orgmode@gnu.org; Wed, 14 Sep 2016 23:12:24 -0400
Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bkLS2-0003NV-UB
	for emacs-orgmode@gnu.org; Thu, 15 Sep 2016 03:26:54 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Justin Kirby <justinkirby@gmail.com> writes:

> In ob-sql postgres would ignore dbport header argument. Attached is a
> patch that corrects this.
>
> Let me know if there are any modifications needed.
>

Three things:

o This probably qualifies as a TINYCHANGE and can be merged, but if
  you want to contribute in the future, you will probably have to sign
  the FSF copyright assignment (unless you have done so
  already). Details can be found at

   http://orgmode.org/worg/org-contribute.html#orgheadline1

o The best way to submit patches is by using ``git format-patch''.
  There are also conventions that you need to follow - details can be
  found at

   http://orgmode.org/worg/org-contribute.html#patches

  Since org-mode is a part of emacs, you will need to add a commit
  message that is formatted as an Emacs ChangeLog entry. The URL above
  has all the details.

o On the positive side, the news entry and the test(s) you provided are
  very much appreciated.

Nicolas Goaziou (or another maintainer) may want to add to this, but I
think it covers the basics.

Thanks!
-- 
Nick