From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Frederick Giasson <fred@fgiasson.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] New header parameter :show-process for Org-babel-clojure
Date: Sat, 19 Nov 2016 08:40:33 +0100 [thread overview]
Message-ID: <87r367lxxq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <22d62a37-c714-ff60-0160-3fbda9771637@fgiasson.com> (Frederick Giasson's message of "Fri, 18 Nov 2016 12:02:16 -0500")
Hello,
Frederick Giasson <fred@fgiasson.com> writes:
>> Could you recreate the commit so it is self-contained?
>
> That should be it.
Thank you. I applied your patch with the following changes:
- I wrote a proper (according to our usage) commit message;
- I slightly refactored the code;
- I required an expected value for :show-process, much like other head
arguments. So a bare ":show-process" means ":show-process nil" and,
therefore, doesn't show process. Use ":show-process t" instead.
BTW, could you document the new feature in
<http://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html>?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-11-19 7:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 19:19 [PATCH] New header parameter :show-process for Org-babel-clojure Frederick Giasson
2016-11-10 15:18 ` Nicolas Goaziou
2016-11-10 17:20 ` Frederick Giasson
2016-11-10 23:55 ` Nicolas Goaziou
2016-11-14 20:46 ` Frederick Giasson
2016-11-15 7:49 ` Nicolas Goaziou
2016-11-17 13:39 ` Frederick Giasson
2016-11-17 23:06 ` Nicolas Goaziou
2016-11-18 15:03 ` Aaron Ecay
2016-11-18 15:09 ` Frederick Giasson
2016-11-18 15:49 ` Nicolas Goaziou
2016-11-18 17:02 ` Frederick Giasson
2016-11-19 7:40 ` Nicolas Goaziou [this message]
2016-11-18 15:31 ` Frederick Giasson
2016-11-18 15:12 ` Frederick Giasson
2016-11-18 15:51 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r367lxxq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=fred@fgiasson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).