From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] New header parameter :show-process for Org-babel-clojure
Date: Sat, 19 Nov 2016 08:40:33 +0100
Message-ID: <87r367lxxq.fsf@nicolasgoaziou.fr>
References: <036bf007-5e9c-310c-5bf8-0660c1b96a5c@fgiasson.com>
	<87lgwrgy7z.fsf@nicolasgoaziou.fr>
	<794c93aa-e2dc-2bfb-537e-0c89d8d34cea@fgiasson.com>
	<878tslp4ha.fsf@nicolasgoaziou.fr>
	<27089048-9dab-747f-51dc-20006717866e@fgiasson.com>
	<87inrlogee.fsf@nicolasgoaziou.fr> <87k2c0n82s.fsf@gmail.com>
	<db4f85fb-2fea-17c1-15ca-a3f1a7dd2282@fgiasson.com>
	<87twb4n5z7.fsf@nicolasgoaziou.fr>
	<22d62a37-c714-ff60-0160-3fbda9771637@fgiasson.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c80GL-0003Mp-Eu
	for emacs-orgmode@gnu.org; Sat, 19 Nov 2016 02:40:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c80GH-0007yw-H6
	for emacs-orgmode@gnu.org; Sat, 19 Nov 2016 02:40:37 -0500
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36220)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1c80GH-0007yr-AO
	for emacs-orgmode@gnu.org; Sat, 19 Nov 2016 02:40:33 -0500
In-Reply-To: <22d62a37-c714-ff60-0160-3fbda9771637@fgiasson.com> (Frederick
	Giasson's message of "Fri, 18 Nov 2016 12:02:16 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Frederick Giasson <fred@fgiasson.com>
Cc: emacs-orgmode@gnu.org

Hello,

Frederick Giasson <fred@fgiasson.com> writes:

>> Could you recreate the commit so it is self-contained?
>
> That should be it.

Thank you. I applied your patch with the following changes:

  - I wrote a proper (according to our usage) commit message;

  - I slightly refactored the code;

  - I required an expected value for :show-process, much like other head
    arguments. So a bare ":show-process" means ":show-process nil" and,
    therefore, doesn't show process. Use ":show-process t" instead.

BTW, could you document the new feature in
<http://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html>?

Regards,

-- 
Nicolas Goaziou