From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Refactor org-set-tags arguments for clarity
Date: Thu, 13 Jul 2017 13:58:10 +0200 [thread overview]
Message-ID: <87r2xkft0t.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY1ECiNyyRTUi-AQH-8H8-Xu=sU_S-fW2iurgVWwm-fB0w@mail.gmail.com> (Kaushal Modi's message of "Thu, 13 Jul 2017 10:18:25 +0000")
Kaushal Modi <kaushal.modi@gmail.com> writes:
> I was itching to do that. But there are dozens of (org-set-tags nil t)
Calls in code base do not matter, since we can change them. The above
Sexp would be equivalent to
(org-set-tags 'current)
> instances in the Org source itself. I though just created a wrapper in my
> personal config to do ALIGN-ONLY-CURRENT when prefix is C-u C-u.
I don't think an user needs to distinguish between aligning all and
aligning only current. I think this is just confusing.
> PS: Also, in addition, was thinking of calling JUST-ALIGN ALIGN-ALL
> instead.
Sounds good.
> With:
>
> (defun org-set-tags (&optional ALIGN-ALL ALIGN-ONLY-CURRENT) ..
>
> it will be more apparent that they are mutually exclusive args.
It still bugs me because (org-set-tags t t) doesn't make any sense.
WDYT?
Regards,
next prev parent reply other threads:[~2017-07-13 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 2:46 [PATCH] Refactor org-set-tags arguments for clarity Kaushal Modi
2017-07-13 7:54 ` Nicolas Goaziou
2017-07-13 10:18 ` Kaushal Modi
2017-07-13 11:58 ` Nicolas Goaziou [this message]
2017-07-13 12:21 ` Kaushal Modi
2017-07-13 12:31 ` Nicolas Goaziou
2017-07-13 12:37 ` Kaushal Modi
2017-07-13 12:39 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2xkft0t.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).