From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Refactor org-set-tags arguments for clarity
Date: Thu, 13 Jul 2017 13:58:10 +0200
Message-ID: <87r2xkft0t.fsf@nicolasgoaziou.fr>
References: <CAFyQvY1aDNQgnwwtWaC00Z__okrDT_Y0RLbPko-_=tNc+pNZjA@mail.gmail.com>
	<87pod4zs9i.fsf@nicolasgoaziou.fr>
	<CAFyQvY1ECiNyyRTUi-AQH-8H8-Xu=sU_S-fW2iurgVWwm-fB0w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dVclA-0005sn-Gs
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 07:58:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dVcl7-0001Oc-Ey
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 07:58:20 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54076)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dVcl7-0001N4-88
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 07:58:17 -0400
In-Reply-To: <CAFyQvY1ECiNyyRTUi-AQH-8H8-Xu=sU_S-fW2iurgVWwm-fB0w@mail.gmail.com>
	(Kaushal Modi's message of "Thu, 13 Jul 2017 10:18:25 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>

Kaushal Modi <kaushal.modi@gmail.com> writes:

> I was itching to do that. But there are dozens of (org-set-tags nil t)

Calls in code base do not matter, since we can change them. The above
Sexp would be equivalent to 

  (org-set-tags 'current)

> instances in the Org source itself. I though just created a wrapper in my
> personal config to do ALIGN-ONLY-CURRENT when prefix is C-u C-u.

I don't think an user needs to distinguish between aligning all and
aligning only current. I think this is just confusing.

> PS: Also, in addition, was thinking of calling JUST-ALIGN ALIGN-ALL
> instead.

Sounds good.

> With:
>
>     (defun org-set-tags (&optional ALIGN-ALL ALIGN-ONLY-CURRENT) ..
>
> it will be more apparent that they are mutually exclusive args.

It still bugs me because (org-set-tags t t) doesn't make any sense.

WDYT?

Regards,